Postal Code

Hello,

Found few minor issues in your code. Here is the link to your error report.
Will let you know issues, if any after manual review.

Hi sanchi.girotra,

Made a manual review of your code just a couple of issues related to t() function.

- On line 88 of postal_code.module you have included HTML tags within t() function, which is wrong. Use HTML tags outside t() function and append the string.

- Have not used t() function on line 83, 93 and 100 of postal_code.module.

Cheers
Mantish

Reviewed Module with #comment-6230330

Welcome with you application.

You have not listed similar projects. How does your module differ from http://drupal.org/project/postal_code_validation? Similarities/differences?

I'm not sure to understand why you wrote $element; in postal_code.module, line 169?

Also line 173, you defined $settings = $widget['settings']; but it is never used.

Following Drupal standards, your variable names should use underscore:
$countrylistitems --> $country_list_items

Hi sanchi.girotra,
After a quick review of the module i have one question: Wouldn't be possible reaching the same goal, just creating a widget for text-field extending its instance settings (for choose the allowed countries) and with its own validation (postal code validation over the countries chosen) avoiding new global variables and the insertions in db through variable_set;

Why a new field type is necessary?

Thank you!!

questions are no issues - therefore no reason to set needs work.

manual review:

1. please add the differences to existing module to your project page, so that users can choose better.
2. why do you need the global variable $_postal_code_validation? I see no reason for that. Please remove the global variable.
3. postal_code_install(): no need to set variables on installation as you can use default values with variable_get() anyway.
4. postal_code_validation(): looks like an important function that should live in the module file.
5. postal_code.module: do not include other files globally, include them in function when you actually need them.
6. "'access arguments' => array('administer users'),": that permission does not fit at all?
7. postal_code_form(): I think you implemented hook_form() per accident, rename that function. And for the doc block: http://drupal.org/node/1354#forms
8. use system_settings_form() in your form constructor then you don't need your submit callback at all.
9. "'Postal Code: ' . $countrylist[drupal_strtoupper($country)],": all user facing text should run through t() for translation and you should use a placeholder for the country.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Reviewed Module with #comment 6233486 ,6233456

manual review:

1. "'#title' => 'Valid "Any" Countries',": all user facing text must run through t() for translation. Same for '"'#title' => 'Validate',".
2. postal_code_regexes.inc should be removed now, right?
3. postal_code_uninstall(): this is a bit dangerous, you would also remove variables from a module called "postal_code_validation". Explicitly name the variables here.

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

The link in your .info is not properly commented out by ;

return t($helptext);
Never ever put variables directly into t()!
The translation system at localize.drupal.org is only able to detect and translate static strings within t() functions
Your help text can't be translated because of this.

t('I am translatable!');
$text = 'I am not!';
t($text);

Don't use 0 or 1 for boolean values, always use TRUE and FALSE!

sanchi.girotra, you are already a git vetted user. There's no need to go through this process again...