Splunk is a log management and log analysis platform. This module is designed for their cloud solution called Splunk Storm. It hooks watchdog and sends the log information to Splunk Storm using their REST API.

Git Repo:
git clone --recursive --branch master http://git.drupal.org/sandbox/ekristen/1683082.git splunk_storm

Sandbox Project Website:
http://drupal.org/sandbox/ekristen/1683082

Comments

sanchi.girotra’s picture

Status: Needs review » Needs work

Please see the automated review report here.
Manual Review:

  1. .info file - Remove version = "7.x-1.0" as added by drupal.org when a release is created refer http://drupal.org/node/231036
  2. Suggestion:Varaible name should start with module name.
ekristen’s picture

Status: Needs work » Needs review

I have removed version from the .info file.

I have renamed all variables from splunkstorm to splunk_storm.

I have also fixed all issues from the automated review report.

japerry’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed .info, .install, and .module files for code standards, looks good to me.

patrickd’s picture

Status: Reviewed & tested by the community » Fixed

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

splunk_storm_menu():
'description' => '', Use it or remove it.

(IMHO) Giving people the access to site reports does not mean they should be allowed to change report settings,
'access arguments' => array('access site reports'),

If there's a wrapping function for a global variable, use it. (eg. rather use base_path() than $base_path)

You don't need to reinvent the wheel, you can use drupal_http_build_query() for building the query string.

I don't like the idea of making blocking (synchronous) curl requests on every page where a watchdog entry is created. Think about queuing the entries for cron run or use non-blocking requests (have a look at http://drupal.org/project/httprl).

rather than defining the temporary but global variable $log_format, you may use the string directly..

define('SPLUNKSTORM_LOG_FORMAT', "date=!timestamp
url=!base_url
type=!type
ip=!ip
uri=!request_uri
referer=!referer
user=!uid
link=!link
message=!message");

If you have persistent variables with non-dynamic names, rather use variable_del() to delete them.

But none of these things are major and should be blockers, therefore:

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

ekristen’s picture

Awesome thanks for all the info. I'll definitely review and see if I can tweak the code to take advantage of several of the items out outlined.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.