Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jul 2012 at 20:57 UTC
Updated:
21 Aug 2012 at 14:31 UTC
Splunk is a log management and log analysis platform. This module is designed for their cloud solution called Splunk Storm. It hooks watchdog and sends the log information to Splunk Storm using their REST API.
Git Repo:
git clone --recursive --branch master http://git.drupal.org/sandbox/ekristen/1683082.git splunk_storm
Sandbox Project Website:
http://drupal.org/sandbox/ekristen/1683082
Comments
Comment #1
sanchi.girotra commentedPlease see the automated review report here.
Manual Review:
Comment #2
ekristen commentedI have removed version from the .info file.
I have renamed all variables from splunkstorm to splunk_storm.
I have also fixed all issues from the automated review report.
Comment #3
japerryReviewed .info, .install, and .module files for code standards, looks good to me.
Comment #4
patrickd commentedAs installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.
splunk_storm_menu():
'description' => '',Use it or remove it.(IMHO) Giving people the access to site reports does not mean they should be allowed to change report settings,
'access arguments' => array('access site reports'),If there's a wrapping function for a global variable, use it. (eg. rather use base_path() than $base_path)
You don't need to reinvent the wheel, you can use drupal_http_build_query() for building the query string.
I don't like the idea of making blocking (synchronous) curl requests on every page where a watchdog entry is created. Think about queuing the entries for cron run or use non-blocking requests (have a look at http://drupal.org/project/httprl).
rather than defining the temporary but global variable $log_format, you may use the string directly..
If you have persistent variables with non-dynamic names, rather use variable_del() to delete them.
But none of these things are major and should be blockers, therefore:
Thanks for your contribution!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #5
ekristen commentedAwesome thanks for all the info. I'll definitely review and see if I can tweak the code to take advantage of several of the items out outlined.