Composed Field

Added the git command to download the module.

Corrected the git command.

Added list of other projects reviewing done by me.

php_eval was actually the first thing I used but I couldn't get it to work.

You can do the experiment yourself, first add the following code into #ajax attribute at the field widget form:

// PS: Include the PHP tags as well.
return array('callback' => 'mycallbackfunction');

Then change these lines:

   // ...
      if ($is_php && !empty($value)) {
        // Evaluate the php code.
        $element[$form_control_attributes_name] = eval($value);
      }

to

  // ...
      if ($is_php && !empty($value)) {
        // Evaluate the php code.
        $element[$form_control_attributes_name] = php_eval($value);
      }

The ajax module will give you a nasty error.


There are no errors in ventral but warnings. The warnings are related to code comment lines that spans over 80 characters. Those lines are URLs for @see.

Thank you.

Tagging PAReview: review bonus.

Presumably #3 is because as the docs for php_eval() state, you need to surround code in <? php ?> tags to use it (unlike eval()).

Nope, that's not the case. In this particular case, no clue why, php_eval just does not work.

Notice: Undefined offset: 2 in _composed_field_build_vertical_tab_elements() (line 401 of < code >sites/all/modules/composed_field/composed_field.module)

I could not reproduce that. Yes, my php.ini error_reporting = E_ALL | E_STRICT (Show all errors, warnings and notices including coding standards.)

Just make sure your caches are cleared and let me know if you or anyone else still get that.

When the vertical tabs are built (successfully despite the above notice), and I wanted to add a #title for each of my sub-fields, I clicked on the #title vertical tab, then checked "Enable #title attribute for Subfield 1". The AJAX throbber whirred and then, a little bit frustratingly, the #type vertical tab was selected again. So I go back to the #title tab, enter my first subfield title, and then check "Enable #title attribute for Subfield 2". And of course the #type tab gets selected again.

Yes, I find that annoying too. To be very honest, I don't know how to implement it.

As you had pointed out this will need some jQuery. I opened a feature request issue here #1682002: Keep the tab selection focused on the same tab that was selected before the ajax rebuilding. If you or anyone else could spare some time helping me out on this one I would very much appreciate it, and also buy you a cup of coffee.
EDITED: I fixed it with no need to implement any jQuery.

In the #required tab, when I select "Enable #required attribute for Subfield 1", as well as negotiating problem (3), I also have to select "Make required". That seems like too many clicks. Could it just be a "Make Subfield 1 required" checkbox?

Done, fixed it.

The Field collection uses a different approach for creating composed fields. Here are the main differences between this module and the "Field Collection":

The host field created by "Field Collection" is in fact an entity that gets attached to the fieldable entities (nodes, taxonomy, comment, commerce products, etc). So, although you attach a Field Collection through the Field UI, what is being attached is not a field but an entity.

Once you get your new entity (host field) attached to your fieldable entity (node, comment, taxonomy, commerce product, etc) then you have to attach the fields ( what would be the subfields ) into the host field ( Field Collection entity).

Each subfield is actually a field on its own, that is, from the database point of view, each subfield is a single field.

"Composed Field" on the other hand attaches a field (host field), not an entity, to your fieldable entities (node, comment, taxonomy, commerce product, etc) through the Field UI. At the end of the day, even if you set a field with say 4 subfields, you will end up having only one field and a single value saved into the database.

Unless you have a very specific use case need "Composed Field" should do what you need with less effort and less resources.

I have added the above information into the Composed Field page.

Although Field Collection and Composed Field can produce the same result, these 2 modules are fundamentally different and I do not see competition going on here.

To avoid controversy on that interpretation I have switched my attention back over to my old application at http://drupal.org/node/1246104

Reviews of other projects