Hi,

When trying to delete an consumer I get the following error:

Trying to get property of non-object in oauth_common_form_consumer_delete()

followed by a WSOD.

Looking at the function I assume the $consumer varible paste to it is in the wrong format. However this hack fixes it as well:
function oauth_common_form_consumer_delete($form_state, $consumer) {
drupal_set_message ("

".print_r($consumer, TRUE)."

");
$form = array(
'consumer_object' => array(
'#type' => 'value',
'#value' => $consumer['build_info']['args'][0],
),
'confirm' => array(
'#type' => 'item',
'#markup' => t('Are you sure you want to delete application @a?', array('@a' => $consumer['build_info']['args'][0]->name)),
),

gr w

CommentFileSizeAuthor
#3 oauth-fix_for_non_object_consumer_delete-1678632-6751214.patch1.22 KBalejandrard

Comments

alejandrard’s picture

alejandrard commented

This hack will also works.


function oauth_common_form_consumer_delete_submit($form, &$form_state) {

  $consumer = $form_state['values']['consumer_object']['build_info']['args'][0];

  $consumer->delete();
  
  drupal_set_message(t('Deleted the consumer @name', array('@name' => $consumer->name)));

  drupal_goto(sprintf('user/%d/oauth/consumers', $consumer->uid));
}
alejandrard’s picture

alejandrard commented

After testing for a while found that it needed a little more than the hacks describe above.

Adding this two lines to the top of function oauth_common_form_consumer_delete and and change #value on consumer_object from $consumer to $consumer_object.

 $consumer_object = new stdClass();
 $consumer_object = $consumer['build_info']['args'][0];

Adding this two lines to the top of function oauth_common_form_consumer_delete_submit

 $consumer = new stdClass();
 $consumer = (object) $form_state['build_info']['args'][0];
alejandrard’s picture

alejandrard commented
StatusFileSize
new oauth-fix_for_non_object_consumer_delete-1678632-6751214.patch1.22 KB

Here is the patch for the comment #2

rjbrown99’s picture

rjbrown99 commented
Status: Active » Needs review

Patch here, changing status.