Notices are raised every time a vocabulary is added:
Notice: Undefined index: module in nodeorder_form_alter() (line 39 of ....\sites\all\modules\contrib\nodeorder\nodeorder.module).
Notice: Undefined index: module in nodeorder_taxonomy_form_vocabulary_submit() (line 69 of ....\sites\all\modules\contrib\nodeorder\nodeorder.module).

CommentFileSizeAuthor
#2 nodeorder-notices_raised-1678864-2.patch4.84 KBben.kyriakou

Comments

mfernea’s picture

mfernea commented
Version: 7.x-1.1 » 7.x-1.2
ben.kyriakou’s picture

ben.kyriakou commented
Status: Active » Needs review
StatusFileSize
new nodeorder-notices_raised-1678864-2.patch4.84 KB

Patch attached. I've swapped to use the vocabulary stored in the form where appropriate as per the taxonomy module, and added checks to make sure that the form alterations are only applied to the editing form. Since there currently doesn't appear to be any behaviour on term deletion, not having the submit handler attached shouldn't break anything.

  • dieuwe committed 35abe2a on 7.x-1.x authored by ben.kyriakou 
    Issue #1678864, by mfernea and ben.kyriakou: Notices raised after adding...
dieuwe’s picture

dieuwe
Location Auckland, NZ
commented
Version: 7.x-1.2 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.