DateObject::limitGranularity() doesn't work when passed array contains zeroes [#1679552]

Posted by Dmitriy.trt on July 11, 2012 at 4:21pm

2 followers

Issue Summary

When you pass field settings with at least one zero value to the DateObject::limitGranularity(), it doesn't filter out anything, because non-strict comparison returns match for any granularity string and integer zero.

Patch follows.

Comments

#1

Posted by Dmitriy.trt on July 11, 2012 at 4:24pm

Status:

active

» needs review

Fix and a test.

Attachment	Size	Status	Test result	Operations
date-1679552-1.patch	2.03 KB	Idle	PASSED: [[SimpleTest]]: [MySQL] 5,238 pass(es).	View details \| Re-test

#2

Posted by barami on January 21, 2013 at 7:56am

I have same problem.
It needs to be accept.

Accepet above patch or change code using in_array function to add parameter 'strict' to TRUE.
http://php.net/manual/en/function.in-array.php

default 'strict' parameter is FALSE and it searchs on array keys too.
So, limitGranularity functions always don't remove granularity part.

#3

Posted by barami on January 21, 2013 at 7:55am

Attachment	Size	Status	Test result	Operations
fix_limitGranularity-1679552-3.patch	520 bytes	Test request sent	None	View details

#4

Posted by barami on January 21, 2013 at 8:06am

Merge test case with patch in #2.

Attachment	Size	Status	Test result	Operations
fix_limitGranularity-1679552-4.patch	1.72 KB	Test request sent	None	View details

#5

Posted by barami on January 21, 2013 at 8:45am

Change tab to spaces.

Attachment	Size	Status	Test result	Operations
fix_limitGranularity-1679552-5.patch	1.75 KB	Test request sent	None	View details

Project:	Date
Version:	7.x-2.x-dev
Component:	Date API
Category:	bug report
Priority:	normal
Assigned:	Unassigned
Status:	needs review

DateObject::limitGranularity() doesn't work when passed array contains zeroes

Jump to:

Issue Summary

Comments

#1

#2

#3

#4

#5