Term added twice to search index, inconsistency with taxonomy.module

When updating the search index for a specific node, this module first adds the term itself to the search index before moving on to adding the synonyms. This is completely unnecessary since that is already done by taxonomy.module. This might even be considered harmful as it actually improves the score of the term in the search index. The solution is to simply remove this line:

<?php $text .= ' '. $nodeTerm->name .' '; ?>

Another issue is that the synonyms aren't added in a way that is consistent with how taxonomy.module adds the main terms, which gives them a lower score than the terms (see taxonomy_node_update_index()).

I'd suggest we rewrite the function to collect the synonyms in an array, the same way taxonomy_node_update_index() does:

<?php

function synonyms_nodeapi(&$node, $op, $teaser = NULL, $page = NULL) {
  if ($op == 'update index') {
    $text = array();

    $getTerms = taxonomy_node_get_terms($node->nid);
    foreach($getTerms as $nodeTerm) {
        $childSynonyms = taxonomy_get_synonyms($nodeTerm->tid);
        foreach($childSynonyms as $childSynonym){
            $text[] = $childSynonym;
        }
        $parents = taxonomy_get_parents($nodeTerm->tid);
        foreach($parents as $parent) {
            $text[] = $parent->name;
            $synonyms = taxonomy_get_synonyms($parent->tid);
            foreach($synonyms as $synonym){
                $text[] = $synonym;
            }
        }
    }

  return '<strong>('. implode(', ', $text) .')</strong>';
  }
}

?>