Infinite reloads, aggressive cache and third-party cookie problems, and other javascript improvements

Dear Dave,

I am runnign the 7.x.3.3-beta3 version. I have the issue reported [when third party cookies are turned off - login redirection happens to the site but the login isn't registered in the site]. I am happy to test this patch, but need to know

a) Will this work for the version I am running?
b) What is the command i need to run to patch. I copied the patch file to the fb module directory and ran patch -p1 < 'the filename of the patch', but the patch command complained as follows before i aborted the command.

sudo patch -p1 < fb_login_status_d7.diff
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: fb.theme.css
|===================================================================
|--- fb.theme.css (revision 4260)
|+++ fb.theme.css (working copy)
--------------------------
File to patch: <^C here>

Cheers.

@Dave Cohen

This patch has broken some of my FB apps. Paths which finish in drupal_goto statements that lead to pages with forms are broken because forms could not be submitted, reporting that the form token generated is not valid.

I'm going to try to find exaclty which part has been modified but I cannot do it right now, probably in a few days.

Here is a module that explains exactly what is failing. It works in beta3 but it doesn't in dev branch because of this issue fix.

.info

name = FB 1679924
description = Issue 1679924 example.
core = 7.x

dependencies[] = fb
dependencies[] = fb_canvas

.module

<?php

function fb_1679924_menu() {
  $items = array();
  $items['redirection'] = array(
    'title' => 'Redirection',
    'page callback' => 'fb_1679924_redirection',
    'access arguments' => array('access content'),
  );
  $items['destination'] = array(
    'title' => 'Destination',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('fb_1679924_destination_form'),
    'access arguments' => array('access content'),
  );
  return $items;
}

function fb_1679924_redirection() {
  fb_canvas_goto('destination');
}

function fb_1679924_destination_form($form, &$form_state) {
  $form['text'] = array(
    '#type' => 'textfield',
    '#title' => 'Text',
    '#required' => TRUE,
  );
  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => 'Submit',
  );
  return $form;
}

function fb_1679924_destination_form_submit($form, &$form_state) {
  drupal_set_message('It worked');
}

Yes, I'm using canvas pages.

In the app I'm testing this when I try to submit the form I have the message: "The form has become outdated. Copy any unsaved work in the form below and then reload this page." because validation fails.

If I add to the form $form['#token'] = FALSE it works.

I know the problem is in this commit:
http://drupalcode.org/project/fb.git/commit/bf5a2d8256274139acaa37bb20e6...
because everything works perfectly well before and does not after.

I'm testing git dev version + the patch and this is what I've found, all the tests using the form and module provided in #8:

• The first time I tested: GET /redirection -> 301 /destination -> POST (submit form) /destination -> 200 /destination with JavaScript Reload -> 200 /destination with "It worked" in the messages. I don't like very much the flow, but it worked.
• I think it should have changed the session or something, and the when flow is: GET /redirection ->
  301 /destination - POST (submit form) /destination -> 200 /destination (no "it worked" in message, but submit functions are executed, tested in other forms) -> GET /destination (vía F5/Cmd+R) "It worked" shown.

It seems that there is a problem with flash messages, but the execution flow works. I don't like pretty much the first attempt and JavaScript reloads.
In beta3 I never saw any of the infitite reloads that I found in the past. In that version everything works just fine: no Javascript reloads and form submittion and flash messages worked as expected.

there is no function fb_canvas_redirect any longer