ATAC (Accept Terms And Conditions) is module which add accept terms and conditions check box in user registration page. In has multilingual support and it is very easy to use.

Sandbox link : ATAC
Project link : ATAC
Version : Drupal 6

CommentFileSizeAuthor
atac.zip1.54 KBarun ak

Comments

parwan005’s picture

hi
found only info file in your branch. Commit other files also. Also make sure to remove the master branch. And follow below link to create other branch names http://drupal.org/node/1015226

parwan005’s picture

I just downloaded your attached zip and saw the code. Pls put this module file your branch.

As far as suggestions after manual review done are : -
1) Include README.txt
2) Remove $Id line from info file as its no longer required. Also remove version, datestamp from it. Also you have written core twice, pls correct it.
3) In module file follow doxygen commenting. You can refer it here. In this you have used variable_get at line 90 and 100, and not set there default value, which is incorrect practice. Please set default value when you use this function. Never close the php tag at the end of your file. Refer this for drupal coding standards. Also there is no proper fomatting. Refer same link for it also.

Please Implement these changes and add them to new branch as suggested in #1.

Thanks

klausi’s picture

Priority: Critical » Normal
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1681280
Project 2: http://drupal.org/node/1681312

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

You need to set the status to "needs review" if you want to get a review. We are currently quite busy with all the project applications and I can only review/approve projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

arun ak’s picture

Hi,

How can I change the status of my project?

arun ak’s picture

Status: Active » Needs review

How can I change the status of my project?

parwan005’s picture

Status: Needs review » Needs work

Its done in this comment form dear. In this very same page where you are just above comment textarea there are form fields, which you should use to set status or any change in priority etc. Setting it to needs work from needs review. Please set it again to needs review when you feel you are done with your module again.

arun ak’s picture

Status: Needs work » Needs review
praveen_s’s picture

Category: task » feature
Priority: Normal » Minor

It there any need of terms and conditions in the profile edit page.
As the terms and condition is already accepted by the user at the time of registration....

klausi’s picture

Category: feature » task
Priority: Minor » Normal

Project applications are tasks.

arun ak’s picture

Project: Drupal.org security advisory coverage applications »
Component: module » Code
Priority: Normal » Critical

Followed the commenting standards and correct the coding formats.

arun ak’s picture

needs review.

arun ak’s picture

Project: » Drupal.org security advisory coverage applications
Component: Code » module
jincy_k’s picture

Hi arun,
I just downloaded and installed your module.I couldn't find any instructions in the admin section to manage the settings.It will be difficult for naive users to configure the admin settings.I hope this issue will be addressed soon.

jincy_k’s picture

Status: Needs review » Needs work
klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

Issue summary: View changes

project link updated

avpaderno’s picture

Title: ATAC » [D6] ATAC
Issue summary: View changes
Status: Closed (won't fix) » Closed (duplicate)
Related issues: +#2545934: [D7] Google Analytics Vimeo Video Tracking