As described here (http://drupal.org/node/1312906#comment-5871140), a lot of the video provider data is serialized and cannot be exposed to Views currently. For my site, users would like to be able to sort by video length, and currently, that can't be done with Views.

jec006 recommended putting that request into another issue, so here it is. Anybody have any idea how to pull this off?

CommentFileSizeAuthor
#3 video_embed_field-length-filters-1681920-3.patch6.7 KBwbobeirne

Comments

jodym’s picture

jodym commented

I would really like to know if this is possible as well.... trevorkjorlien did you manage to find a solution?

trevorkjorlien’s picture

trevorkjorlien commented

@jody.mcbride No, it's beyond my skill set at the moment.

wbobeirne’s picture

wbobeirne commented
StatusFileSize
new video_embed_field-length-filters-1681920-3.patch6.7 KB

Hey guys,

I've put some work in to implementing this, but I'm thinking that it could use a lot more work/feedback. Attached a patch for 7.x-2.x.

Things the patch does:

  • Adds a column for video_length on vef fields
  • Updates all existing fields with the length (This may take a long time, depending on how many videos you have)
  • Adds sort and filter for video length (Automatically handled by views)
  • Adds a parameter for video handlers to have a function determine the length of the video based on the data retrieved by the data_function parameter

Things this patch does NOT do:

  • Provide any display of the length in field or view formatter form
  • Provide robust filters. It's the basic views filters, and it only takes input as seconds. Exposing this to users may be problematic without fleshing the filters out.
  • Add the function to determine the length to any handler except vimeo and youtube. Facebook isn't getting any metadata right now, so I can't pull the length out. Custom handlers will have to implement this themselves.

So, do you guys have any requests or ideas on how to improve on what I've got so far?

wbobeirne’s picture

wbobeirne commented
Status: Active » Needs review
trevorkjorlien’s picture

trevorkjorlien commented

Hey, I finally got around to trying this patch out. It mostly worked, save for this error that I got:

patching file video_embed_field.field.inc
Hunk #1 succeeded at 166 (offset -12 lines).
patching file video_embed_field.handlers.inc
patching file video_embed_field.install
patching file video_embed_field.module
Hunk #1 succeeded at 452 (offset -3 lines).
Hunk #2 FAILED at 575.
1 out of 2 hunks FAILED -- saving rejects to file video_embed_field.module.rej

Looks like hunk #2 was this:

/**
 *  Creates a hash for storing or looking up a video in the store table
 */
function _video_embed_field_hash($video_url, $video_style){
  return md5('vef' . $video_url . $video_style);
}
mr.andrey’s picture

mr.andrey commented

Just attempted to apply the patch and got a bunch of rejects on beta11:

patch -p0 < video_embed_field-length-filters-1681920-3.patch
can't find file to patch at input line 7
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/video_embed_field.field.inc b/video_embed_field.field.inc
|old mode 100644
|new mode 100755
|index e1e0d92..d66edd3
|--- a/video_embed_field.field.inc
|+++ b/video_embed_field.field.inc
--------------------------
File to patch: video_embed_field.field.inc
patching file video_embed_field.field.inc
Hunk #1 succeeded at 261 (offset 83 lines).
can't find file to patch at input line 23
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/video_embed_field.handlers.inc b/video_embed_field.handlers.inc
|index 38c7818..b28e566 100755
|--- a/video_embed_field.handlers.inc
|+++ b/video_embed_field.handlers.inc
--------------------------
File to patch: video_embed_field.handlers.inc
patching file video_embed_field.handlers.inc
Hunk #1 succeeded at 20 with fuzz 2 (offset 4 lines).
Hunk #2 FAILED at 41.
Hunk #3 FAILED at 231.
Hunk #4 succeeded at 556 with fuzz 1 (offset 126 lines).
2 out of 4 hunks FAILED -- saving rejects to file video_embed_field.handlers.inc.rej
can't find file to patch at input line 95
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/video_embed_field.install b/video_embed_field.install
|index 0803b80..162c4a9 100755
|--- a/video_embed_field.install
|+++ b/video_embed_field.install
--------------------------
File to patch: video_embed_field.install
patching file video_embed_field.install
Hunk #1 succeeded at 42 with fuzz 1 (offset 5 lines).
Hunk #2 FAILED at 239.
1 out of 2 hunks FAILED -- saving rejects to file video_embed_field.install.rej
can't find file to patch at input line 178
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/video_embed_field.module b/video_embed_field.module
|index 8a45ebb..8a1673b 100755
|--- a/video_embed_field.module
|+++ b/video_embed_field.module
--------------------------
File to patch: video_embed_field.module
patching file video_embed_field.module
Hunk #1 succeeded at 447 with fuzz 2 (offset -8 lines).
Hunk #2 FAILED at 578.
1 out of 2 hunks FAILED -- saving rejects to file video_embed_field.module.rej