This was an idea I got in the lengthy discussion at http://drupal.org/node/167985#comment-290041. This will make it possible for users with the 'inspect all votes' permission to always see the result even if it's not set to "Always".

Information wise it can be seen as a summary of the votes displayed on that page, thus we're not giving away more info to that permission then we already did. UI wise it feels a bit like a hack but I like it anyway. What do you think?

Is it "Result" or "Results"?

CommentFileSizeAuthor
advpoll_votesandresult.patch1.06 KBanders.fajerson

Comments

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Needs work

I think this a little clunky and unnecessary. For example, it shows the "cancel vote" button inside of the fieldset and looks strange.

True, it's not giving away more information per se, but computing the results for a ranking poll isn't exactly trivial, depending on the algorithm (especially as we add more). I'm more inclined to say the converse option: we should hide the individual votes based on the show results setting.

But once the permissions tweaking patch gets in, it might even be worthwhile to revisit the option of making the "show results" setting per-poll, but only for "administer nodes" users. Now that we have a collapsed settings fieldset and will soon have administrator-only settings, the settings bloat would be pretty negligible.

anders.fajerson’s picture

anders.fajerson commented
Status: Needs work » Closed (won't fix)

I will never change my mind! Kidding, looking at the edit page with my dates and permission patch it looks cleaner, so adding a per-poll result setting *might* be an option.