Facebook API breaks Collapsible Fieldsets in Overlay

I found a possible type-o in the fb.js file.

There was a closing curly brace on an if statement followed by ');'. After I removed the ');' the module does not disable the collapsible fieldsets. I haven't done much testing with it, but added a patch file to this post. Not sure if the ');' needed to be there, but at a quick glance, it appeared that it should not be.

window.fbAsyncInit = function() {

if (Drupal.settings.fb) {
FB.init(Drupal.settings.fb.fb_init_settings);
}

// Facebook recommends calling getLoginStatus after FB.init (http://developers.facebook.com/docs/reference/javascript/FB.getLoginStatus/)
// However, it's got lots of bugs reported against it (https://developers.facebook.com/bugs/240058389381072, http://developers.facebook.com/bugs/173032012783482?browse=search_4ecd4a...)
// So we make it optional whether we call it or not.
if (Drupal.settings.fb.get_login_status) {
FB.getLoginStatus(function(response) {
FB_JS.initFinal(response);
FB_JS.authResponseChange(response);
});
}
else if (Drupal.settings.fb.fb_init_settings.authResponse) {
// Our authResponse sent to us from fb.module.
FB_JS.initFinal({'authResponse' : Drupal.settings.fb.fb_init_settings.authResponse});
}
else {
// No application. Not safe to call FB.getLoginStatus().
// Or, we are configured to not call getLoginStatus().
// We still want to initialize XFBML, third-party modules, etc.
FB_JS.initFinal({'authResponse' : null});
}

if (!Drupal.settings.fb.get_login_status && Drupal.settings.fb.test_login_status && FB.getUserID()) {
// This is an alternative to calling getLoginStatus(). Adds some overhead to the client side by calling FB.api on every page. But, will detect if user has logged out of facebook.
FB.api('/me', function(response) {
// Calling FB.api is unfortunate overhead, but no other way to detect if user has logged out of facebook.
if (typeof(response.error) != 'undefined') {
// Fake an auth response change so Drupal knows user is logged out.
FB_JS.authResponseChange({'authResponse' : null});
}
else if (response.id != Drupal.settings.fb.fbu) {
// Fake an auth response change so Drupal knows user has changed.
FB_JS.authResponseChange({'authResponse' : {'userID' : response.id}});
}
});
}
};

Nevermind, after looking at the call further it appears it does belong there. But removing the ');' does fix the collapsible fieldset issue. This only started occuring after the upgrade to 3.3-beta2

Yeah i did notice it was hard to read, but that wasnt the issue anyway after i took a harded look at the fb.js file. but i can reproduce the issue on a clean install of both drupal and the fb module. just enable the fb api and there go the collapsible links in the overlay. i will check a bit more with firebug after lunch.

Can you possibly narrow down the D6 patches that were implemented in the 3.3-beta2? I put a break in Firebug on entering the collapse.js and the fb.js and i'm not seeing much -- other than the collapse.js jumps over the function that actually enables the links for collapsible fields.

Granted, I am relatively new to Drupal (only about a year or 2 in) and I haven't written much javascript/jQuery/php in a LONG time as my function is geared more to Linux admin/networking/infrastructure support, but I am enjoying getting back to debugging code.

I did download the 3.3-beta1 and ran a diff on the fb.js between the two and the changes are abundant. But I'm not sure if the problem lies within the fb.js or not.

This issue is also affecting the ability to run an available updates check with the admin overlay. Again, take the admin overlay out, everything works as expected, but collapsible fieldsets and even the check for updates is broken with the 3.3-beta2.

When debugging the collapse.js, it gets into Drupal.behaviors.collapse, hits the 'attach: function(context settings)' and then jumps down to the bottom of the function, bypassing the entire 'attach: function(context, settings)' function.

Drupal.behaviors.collapse = {
  attach: function (context, settings) {
    $('fieldset.collapsible', context).once('collapse', function () {
    var $fieldset = $(this);
    // Expand fieldset if there are errors inside, or if it contains an
    // element that is targeted by the uri fragment identifier.
    var anchor = location.hash && location.hash != '#' ? ', ' + location.hash : '';
    if ($('.error' + anchor, $fieldset).length) {
    $fieldset.removeClass('collapsed');
  } 

That patch worked for me.