Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jul 2012 at 11:23 UTC
Updated:
10 Sep 2018 at 07:58 UTC
Jump to comment: Most recent
Comments
Comment #1
parwan005 commentedHey,
you have only info file in your master branch. Please add all of your modules files in a branch and remove this master branch. For naming conventions refer this. Make sure to delete your master branch after above.
Thanks
Comment #2
harings_rob commentedif i'm not mistaking i did upload all files.
I'm abit new to the whole Git thing. I'll look into it.
Comment #3
thedavidmeister commentedAbout to have a look at this, but one very obvious issue is that Ubercart is spelt incorrectly in the project title.
Tortelduif, is English a second language for you? If it is it might be worth getting somebody to review your grammar and spelling for the project as all your documentation will need to read well.
Incidentally, I'm having the same problem as parwan005. There's nothing but a .info file in the master branch, and I can't see any other branches.
You may well have a 6.x-1.x branch locally but you need to push that branch to the repository hosted on drupal.org before anybody else can use it.
If you're new to git you might want to use something with a graphical UI to smooth out the learning curve. I've found that http://www.git-tower.com/ is pretty good if you're using a mac.
Comment #4
thedavidmeister commentedAlso, you need to go over the instructions at http://drupal.org/node/1011698 once more.
It clearly states that you should set the status of your issue in this queue to "needs review".
Comment #5
patrickd commentedYour project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.
It seems that your project´s repository contains no code yet, please have a look at the documentation about using GIT on drupal.org.
You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Comment #6
harings_rob commentedI cant seem to figure out how to push my module file to with GIT.. git push, git add is not working. Anyone knows what i'm doing wrong?
If nobody can help me i'll just keep the module for personal use.
Comment #7
harings_rob commentedManaged to get my files uploaded
Also updated my info file. Getting the hang of it.
Comment #8
thedavidmeister commenteddid you try the link to tower that I posted? pushing a local git branch to a remote is really simple through their UI. There's also a 30 day free trial if you don't want to pay.
Comment #9
tr commentedYou only need to submit ONE application for git access. You have two. I'm closing this one and marking it as a duplicate of #1701498: [D7] Open Icecat product database data collector because that one has a lot more comments indicating that reviewers have spent more time on it. EVERYTHING that is pointed out in that issue applies to ALL your projects, this one included. If you look, you'll see you're being told the same thing in each queue - this just slows down the process and duplicates reviewer effort which could be better spent elsewhere.
Comment #10
avpaderno