SoShake is a product created by our company Up 2 Social. We enhance the social sharing of content by offering abilities to content creator to display a message after a content is shared on a social network.
eg :
You can show related content when a post is "liked"
You can show a fanbox when a post is tweeted
You can show a newsletter form when a post is posted on Pinterest
And so on...

To facilitate the integration of our social buttons, we developped a plugin for Drupal 7.
Our Git repository : http://git.drupal.org/sandbox/up2social/1681302.git
Our project page : http://drupal.org/sandbox/up2social/1681302

You can learn more about us :
http://up2social.com
http://soshake.com
@soshake
http://facebook.com/up2social
http://facebook.com/soshake

Thank you for the time spent on our plugin to review it

Changes have been made after the first response. Updates have been Commited. Module has been scanned by the "Coder Module". No warnings left

Comments

sanchi.girotra’s picture

sanchi.girotra commented
Status: Needs review » Needs work

1.Please provide the correct project link as "http://drupal.org/sandbox/up2social/1681302" in the issue summary.
2.Please provide the correct git link as "git clone http://git.drupal.org/sandbox/up2social/1681302.git soshake" and also provide version info in the issue summary. Please refer http://drupal.org/node/1011698.
3.Please use Coder Module to review your project and see the automated review report here.
Manual Review:
1.Please use variable name starting from module name in "up2-SoShake-layout" ,"up2-SoShake-align" etc.
2.Please uninstall variables used in the module from variable table when the module is uninstalled.

up2social’s picture

up2social commented
Status: Needs work » Needs review

Corrections have been made.

Thanks for the input !

up2social’s picture

up2social commented
Issue summary: View changes

Correction after first comment

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented
Status: Needs review » Needs work

Firstly, your link to Repo is still incorrect, it should be - http://git.drupal.org/sandbox/up2social/1681302.git

Please check on the issues from automation testing - http://ventral.org/pareview/httpgitdrupalorgsandboxup2social1681302git
Try to clear all the bugs here and then you can apply for Review bonus - http://drupal.org/node/1410826

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented
Issue summary: View changes

git repository correction

up2social’s picture

up2social commented
Status: Needs work » Needs review

Hello,

We have made changes to correct our Git repo link.
Our module is now on a branch (7.x) and no longer on master
We have cleared every errors shown on ventral.org

Thanks for the input, guess now our code is clean !

Anonymous’s picture

Anonymous (not verified) commented

I don't understand why you set up the block manually in the db (via .install file) while you could do it through hook_block_info

lord_of_freaks’s picture

lord_of_freaks commented
Status: Needs review » Needs work

Cloned from 7.x brach

Link: git clone --recursive --branch 7.x http://git.drupal.org/sandbox/up2social/1681302.git soshake

Please Move from master to a 7.x-1.x version branch and set default 7.x-1.x to default brach such as the example does.

Remove unnecesary code from soshake.module:

/**
 * Custom content function.
 */
function soshake_contents() {
}

I can´t image why all this direct input (via $_POST) is here, and why you are not using a form, maybe could help you the Form API Quickstart Guide

function soshake_block_view($delta = '') {
  global $base_url;
  if (isset($_POST) && isset($_POST["up2FBConnect"]) && $_POST["up2FBConnect"] == 1) {
    $result = db_query("SELECT uid FROM {users} WHERE name = '" . ($_POST["username"]) . "'");
    if (count($result) == 1) {
      user_save(drupal_anonymous_user(), array(
        "pass" => md5($_POST["email"]),
        "name" => $_POST["username"],
        "status" => "1",
        "mail" => $_POST["email"],
      ), 'account');
    }
    $user_number = user_authenticate($_POST["username"], md5($_POST["email"]));
    if ($user_number) {
      $l = array(
        'ldap_auth_login' => 1,
        'name' => $_POST["username"],
        'uid' => $user_number,
      );
      drupal_load('module', 'user');
      $user = user_load($l['uid']);
      user_login_submit('ldap_auth_login', $l);
      unset($_POST["up2FBConnect"]);
    }
  }
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

changes for Git repo