CiviCRM Cicero allows you to add election district information to your CiviCRM contacts using Azavea's commercial Cicero API. You can map fields provided by Cicero to your own custom data fields in CiviCRM and limit contacts to update by CiviCRM groups. The information is updated during cron runs, which can be scheduled by the you.

CiviCRM Cicero is a Drupal 7 module. There are no other Drupal modules that interact with the Ciciro API.

The project page is here: https://drupal.org/sandbox/jmcclelland/1697916

The code can be checkout with:

git clone git://git.drupal.org/sandbox/jmcclelland/1697916.git

Thanks!!

Comments

sanchi.girotra’s picture

sanchi.girotra commented
Status: Needs review » Needs work

1.Please user Coder Module to review your project and see automated project review here.
Manual Review:
1.In Info file remove
version = 4.1
refer http://drupal.org/node/542202.
2.It is not a good practice for hook_init() to be trigger during Drupal installation - i.e. running an install profile.
civicrm_cicero_init()
3.Please provide proper commenting for functions used in .install file.
4.Uninstall variables(civicrm_cicero_account_name,civicrm_cicero_account_pass etc.) in the .install file.

jmcclelland’s picture

jmcclelland commented
Status: Needs work » Needs review

Thanks for the feedback. I've just made all recommendations, except the format of the @return and @param comments. I can't tell how to write those in a way that the coder does not complain about.

patrickd’s picture

patrickd commented

See Doxygen and comment formatting conventions

There are about 100 other applications waiting for review and only a hand full of active reviewers.
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

kreynen’s picture

kreynen commented
Status: Needs review » Reviewed & tested by the community

I tested this and everything worked "as advertised". I created a patch to move the menus one level deeper so they show up in the admin/config and linked the config from the .info file to improve the usability.

#1717370: Move admin menu to /config/civicrm, add link to .info file

While I'd like to see a manual sync option instead of just scheduling a cron job, that's a feature request for future release. Once the project is promoted and has it's project/civicrm_cicero URL, please add it too http://civicrm.org/extensions too.

jmcclelland’s picture

jmcclelland commented

Thank you!! I appreciate your work and feedback. I've applied your patch.

patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Fixed

Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.
The readme on the other hand is quite detailed, please try to keep project page and readme in sync.

sleep(5);
awww, if a sleep is really necessary rather use a smaller value. Anyway there should be a better solution like queuing failed requests for later submission by cron.

$desc = t('');
How and why should this be translated?

More inline documentation would be a great thing, in some functions there's a m(a/e)ss of code what makes it really hard for other developers to understand it.

Whenever possible, don't use arg(), always try to make use of the "callback arguments" functionality of hook_menu().

While glancing over the code I've sometimes seen some human readable text that is not translatable because t() was missing.
Make sure all user faceable and readable text is wrapped in t().

I don't have enough time to fully test the module's functionality, but I couldn't find any major issues while looking at the code.

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.