Support taxonomy term pages until taxonomy supports hook_entity_view()

Has anyone found any solution to this problem?

Subscribing.

I'm new here, so I don't know if there might be something that can be done for the issue referenced in #3 to get the attention of a core committer. It looks like more progress has been made in the last few days on a patch, and they are saying that if it doesn't get committed soon, it will have to be re-rolled. Is there some way to speak up on IRC about it or submit a special request elsewhere to get it committed?

Yes, I saw your offer of food earlier up in the comments on that issue. Smart thinking. Too bad doughnuts can't be emailed or it might actually work. I hadn't thought to apply the patch to D7 myself, so thanks for that (I'm very new to website development). Too bad the patch can't be committed now and save you having to re-do your work. Can they take on a few more core maintainers to help out with the time crunch? Sounds like you know what you are doing and would be a good addition to the team, though I realize the time commitment to being a core maintainer is not possible for everyone.

I can't follow all this technical talk 100%, so I hope someone can clarify for me?

All the Taxonomy changes I make in the Meta Tag module do not have any effect at all: nothing shows up in the code frontend. This is a known issue and I should not investigate further? Thanks a lot.

We need this functionality, so I am adding a patch that will do the job until the hook is implemented

The patch applies without breaking anything, but when I tried to make a change to the way <title> is displayed for taxonomy term pages, my changes are not implemented.

For the taxonomy term page, it was core functionality Drupal 7. I do not have Panels installed. If you want me to create a View to test that, I can. Update: actually, I am concurrently working on a related issue where I have installed a patch from marcelovani that adds page numbers to <title> on Views pages and taxonomy term pages when [current-page:page-number] is added to the Global title settings, so we would not need this patch for Views pagination, because the other one works. That is a major concern for SEO and why I'm following this issue here as related to it.

@DamienMcKenna you are right. It is working for us because we use views to list all nodes that refer to a specific term i.e. /taxonomy/term/6, which triggers the hook_entity_view when loading nodes.

I will try find a better way of fixing this.

This patch didnt work for me.

This logic is much cleaner than the previous one.

I'm not sure if I did something wrong, but I'm getting these warning messages on a taxonomy term page when I applied the patch. The custom title I set up in Meta Tags for taxonomy terms is not showing, either. It is showing only the Global settings.

Warning: Missing argument 3 for metatag_entity_view(), called in /var/www/couturier/fashionbelle.biz/sites/all/modules/metatag/metatag.module on line 455 and defined in metatag_entity_view() (line 462 of /var/www/couturier/fashionbelle.biz/sites/all/modules/metatag/metatag.module).
Warning: Missing argument 4 for metatag_entity_view(), called in /var/www/couturier/fashionbelle.biz/sites/all/modules/metatag/metatag.module on line 455 and defined in metatag_entity_view() (line 462 of /var/www/couturier/fashionbelle.biz/sites/all/modules/metatag/metatag.module).
Notice: Undefined variable: langcode in metatag_entity_view() (line 474 of /var/www/couturier/fashionbelle.biz/sites/all/modules/metatag/metatag.module).
Notice: Undefined variable: view_mode in metatag_entity_view() (line 489 of /var/www/couturier/fashionbelle.biz/sites/all/modules/metatag/metatag.module).

I have added default values for the function:
-function metatag_entity_view($entity, $entity_type, $view_mode, $langcode) {
+function metatag_entity_view($entity, $entity_type, $view_mode = 'full', $langcode = NULL) {

So that if we don't supply the other two arguments, it will use the default values

@DamienMcKenna, I would like to have a chat on skype, are you available: my skype is marcelovani

To make things simpler, I am adding the two parameters when I call hook_entity_view.

I am testing the patch on few sites.

Applying this patch alone won't fix the problem of overriding metatags for nodes/terms.

Image this case scenario:
- I set title metatag for terms to be [term:name] | [site:name] (/admin/config/search/metatags)
- I visit a term page /term/1 and the title shows term1 | test.com
- I edit the term and change the title metatag to Custom title for term1 (/taxonomy/term/1/edit)
- I visit a term page /term/1 and the title shows Custom title for term1

The scenario above will only happen if you also apply this patch http://drupal.org/node/1784896#comment-6534684
Otherwise, it will still show term1 | test.com, because the value gets overriden with the current code.

Please apply both patches (http://drupal.org/files/support-taxonomy-term-pages-1700160_1.patch, http://drupal.org/files/overriding-metatags-fall-back-parent-default-val...) and let me know how it goes, I am testing this on 6 different sites which have different modules and configuration, so far it seems to work fine.

Yes! With these two patches, the titles for taxonomy term pages can be successfully changed, independently from the Global settings.

#23: support-taxonomy-term-pages-1700160.patch queued for re-testing.

@DamienMcKenna I'm not sure what you are asking. Do you want Dave to review the #23 patch? I do not see any alternative to the patch in #23. Or, maybe you mean the patch in #23 plus your new patch here? I can try that.

Yes, this patch in #31 works for me to set unique taxonomy term page titles (separate from Global settings) when used together with your new patch under "Overriding meta tags fall back to parent default tag value".

For me only #9 is working, and all the others are not. Thanks still!

i test the code according to the #32

the patch is a little troublesome to use
so i upload my modified metatag.module file

it has two modify
1. add add line 445-455
2. modify function metatag_page_build() line 861

我测试了32楼的代码，可以正常使用

patch看着有点麻烦
不想麻烦的，可以直接看我上传的metatag.module
改了两个地方
1 是 添加 行445-455
2 修改默认的 function metatag_page_build() 行861

thank you.
dev is better in drupal :-)

I'm using D7.17 and the latest dev release of Metatag but am seeing no meta tags printed on my taxonomy term pages. The tags are in $vars['page']->content['metatags'] but they're simply not being printed. All of my nodes are getting them printed properly. Should I be expecting this to work with 7.17 and 7.x-1.x-dev?

That issue is interesting – following the advice there, I've thrown

<?php
render($vars['page']['content']['metatags']);
?>

into template_preprocess_html() and the metatags are now printing. Still not getting the revised title, however. This makes me think that my issue is related to both this issue and 1310780. Metatags are not being rendered for taxonomy terms, including the title tag.

Does this patch need to be removed from Meta Tag now with the release of Drupal 7.17 on November 7, 2012?

Beta2 works great for me, thanks a lot.

Smart, Damien. Thanks for the forethought in beta2.

Added link to #1363476.