in function autologout_init() there the autologout.js file is included within the following if statement:
if ($user->uid && _autologout_logout_role($user)) {
However, if no roles are checked off in the config form (because you do not have "Role Timeout" checked) then the js file will never be included (and thus, the timeout doesnt work)
There should probably be some kind of check of variable_get('autologout_role_logout') in there as well, no?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | autologout-fix_role_autologouts-1700706-7397974.patch | 14.95 KB | johnennew |
| #3 | autologout-fix_role_autologouts-1700706-6291340.patch | 14.74 KB | johnennew |
| #2 | 1700706.patch | 1.81 KB | bleen |
| #1 | 1700706.patch | 1.95 KB | bleen |
Comments
Comment #1
bleen commentedThis fixes the issue
Comment #2
bleen commentedThis is a reroll now that a couple of the other patches in the queue have been committed
Comment #3
johnennew commentedHi,
I've gone a head and committed the attached patch which builds on #2.
In this new patch:
1. the default value is used if the global role timeout is not enabled as per #2
2. unchecked roles are not used and the user is reverted to the default value (unchecking a role would mean that what ever value was set for the role would still be used)
3. setting a value of 0 for any role is now allowed and this means that anyone with that role is never logged out via autologout.
Comment #4
johnennew commentedSetting to 6.x-4.x branch for backport
Comment #5
johnennew commentedApplied attached patch as backport to 6.x-4.x branch