currently visiting /project/iytgytfjk (read: bad project alias) leads to some funky output, when it should properly return a page not found. attached should correct.

CommentFileSizeAuthor
#5 project_not_found_2.patch2.61 KBhunmonk
#3 project_not_found_1.patch2.27 KBhunmonk
#1 project_not_found_0.patch1.38 KBhunmonk
project_not_found.patch927 byteshunmonk

Comments

hunmonk’s picture

hunmonk commented
StatusFileSize
new project_not_found_0.patch1.38 KB

last patch didn't take all cases into account. this one does, and has been thoroughly tested.

aclight’s picture

aclight commented

The patch looks good and works as expected.

Two things to think about:

1. Do we want a URL such as http://drupal.org/projects/Modules/sdflsfjslf to also go to a page not found? Currently it just gives a list of ALL projects.
2. Do we want to handle the case where the taxonomy module is not enabled but the path is specified?

If the answer to both of the above questions is NO, then I'd say this is RTBC. If YES, then CNW. I'll let you decide.

hunmonk’s picture

hunmonk commented
StatusFileSize
new project_not_found_1.patch2.27 KB

good catches. i think we should be consistent. try this one out, it should also handle the cases you raised.

aclight’s picture

aclight commented
Status: Needs review » Needs work

Sorry, one more thing. It looks like if you sort by name or date then you don't get a page not found if you put in something bogus.

eg. http://drupal.org/project/Modules/name/adfsdf and http://drupal.org/project/Modules/date/sdfsefd

Otherwise it looks good. I don't have a site where it's easy to turn off taxonomy module, so I didn't test that case, but the code looks good.

hunmonk’s picture

hunmonk commented
Status: Needs work » Needs review
StatusFileSize
new project_not_found_2.patch2.61 KB

this function is a real mess -- way too complicated...

but, i'm not going to mess w/ it this close to a D5 branch.

try out this patch, i believe it addresses the other case you found as well.

aclight’s picture

aclight commented
Status: Needs review » Reviewed & tested by the community

Yes, I agree. I keep getting bug reports from users on my site complaining that their project without releases doesn't show up when browsing by name. I created an issue a while back about this and have tried about 3 or 4 times to fix this but couldn't figure out how to do it any of those times. There's way too much going on.

But in any case, your patch works as promised and I can't think of any more situations where page not found should be returned but isn't.

hunmonk’s picture

hunmonk commented
Status: Reviewed & tested by the community » Fixed

fixed in HEAD, 4.7.x-2.x, 4.7.x-1.x

had to make some adjustments to the patch for 4.7.x-1.x, but i'm pretty confident that they worked out fine.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)