Facebook-style avatars in Inbox and messages

You have theme_privatemsg_username , feel free to override that.

No, I do not close this, I also think this would be cool -- but for now , the theme will do.

I also would appreciate the implementation of this request or at least little bit more detailed explanation of how this could be achieved other ways, please.

chx, i am not a programmer and it took me a while to browse and stare at number of pages on drupal.org to realize that i need to override the function in template.php file. it is frustrating that i could not figure out what exactly i need to put in there. it would be very nice if your could give some explanations for not experienced users like me, please.

i hoped i would dig something out on http://api.drupal.org/api/group/themeable/5, but unfortunately i could not find anythign related to private messages module there.

I'll try to see if I can figure it out and if I do I can write up some documentation on it until this gets implemented into privatemsg.

would ne nice, Fayna! looking forward to hear from you.

With current redesign of privatemsg architecture, it will be possible to theme any and all aspects of privatemsg.

stay tuned.

Well, if Drupal gurus have no willing or time to point out how to do this, maybe we, non-coders, can solve this issue by helping each other. I don't need column 'Type' on my site (since all the private messages are of private-message type) and would like to display avatars of message authors instead of this column. So I managed to replace drupal_render($form[$key]['selected']) line in the following function with anything, but user pictures. Who can figure out how to display user pictures instead of drupal_render($form[$key]['selected'])?

function theme_privatemsg_message_table($form) {
  $rows = array();

  foreach (element_children($form) as $key) {
    if ($key != 'current_folder') {
      $classes = array('pm-'. drupal_strtolower(preg_replace('/[^\w]+/i', '_', $form[$key]['type']['#value'])));

      if ($form[$key]['#new']) {
        $classes[] = 'pm-new';
      }
      $rows[] = array(
        'data' => array(
          drupal_render($form[$key]['selected']),
          drupal_render($form[$key]['type']),
          $form[$key]['user']['#value'],
          array('data' => $form[$key]['subject']['#value'], 'width' => '50%'),
          array('data' => $form[$key]['date']['#value'], 'nowrap' => 'nowrap'),
        ),
        'class' => implode(' ', $classes),
      );
    }
  }

If you try the new D6 version you will notice that i've implemented facebook style message view (if you do try it out bear in mind its still in early development stage).

from what i gather you want to also show the player avatar in messages listing page (inbox, etc). i will try to provide a patch later today for you guys to apply. i was going to concentrate on d6 but this seems to be a very requested feature for d5 as well so i might as well do it.

soon to come...

"Another strange thing with my code is that it would only display the avatars, but no Username afterwards."

Not strange at all. The first line in that function is a "return" so it will never get to the second line.

Michelle

Don't pay the $200... i've managed to do this with version 5.x-1.8... there's a few things I had to do, as follows:

1. I created a new function in template.php:
   

   /**
   * theme_avatar function, and redirect through the template api
   */
   function theme_avatar($account) {
     // Pass to phptemplate, including translating the parameters to an associative array.
     // The element names are the names that the variables
     // will be assigned within the template.
     return _phptemplate_callback('avatar', array('account' => $account));
   }
   

2. Then I created the avatar.tpl.php file in the theme directory as follows:
   

   /***
   Customised formatting of the user picture on the site including an online/offline indicator to avatar size.
   
   Modified code from: function theme_user_picture($account) {
   **/
     if (variable_get('user_pictures', 0)) {
       if ($account->picture && file_exists($account->picture)) {
   
         $info = image_get_info($account->picture);
         $newpicture = dirname($account->picture) . '/picture-' . $account->uid . "-avatar." . $info['extension'];
           
         if (!file_exists($newpicture) || (filectime($newpicture) < filectime($account->picture))) {
           image_scale($account->picture, $newpicture, 64, 64); 
           if (!file_exists($newpicture)) {
             $newpicture = $account->picture;
           }
         }
           
         $picture = file_create_url($newpicture);
       } 
       else if (variable_get('user_picture_default', '')) {
         $picture = variable_get('user_picture_default', '');
       }
   
       if (isset($picture)) {
         $alt = t("Go to @user's profile", array('@user' => $account->name ? $account->name : variable_get('anonymous', t('Anonymous'))));
         $picture = theme('image', $picture, $alt, $alt, '', FALSE);
         if (!empty($account->uid) && user_access('access user profiles')) {
           $picture = l($picture, "user/$account->uid", array('title' => t('View user profile.')), NULL, NULL, FALSE, TRUE);
         }
         
   // code to show online/offline status
         $time_period = variable_get('user_block_seconds_online', 1200);
         $uid = $account->uid; // get the current userid for the avatar.
         $users = db_query("SELECT uid, name, access FROM {users} WHERE access >= %d AND uid = %s", time() - $time_period, $uid);
         $total_users = db_num_rows($users);
   
         if ($total_users == 1) {
           $output = '<span style="color: #00DD45; font-weight: bold">' . t('Online') . '</span>';
         }
         else {
           $output = '<span style="color: #AA4444">' . t('Offline') . '</span>';     
         }
         
         print '<div class="picture">' . $picture . $output . '</div>';
           
       }
     }
   

3. Modified (ok, hacked) the privatemsg.module function privatemsg_list_form as follows:
   

       $form['messages'][$message->id] = array();
       $form['messages'][$message->id]['selected'] = array(
           '#type' => 'checkbox',
           );
       $form['messages'][$message->id]['date'] = array(
           '#type' => 'value',
           '#value' => '<div class = "privatemsg_list_date">' . format_date($message->timestamp, 'small') . '</div>' // added class, 2008-05-27, sdsheridan
           );
   // Add an avatar infront of the user-name, 2008-05-27, sdsheridan        
       $authorID = array(
           'uid' => $message->uid
           );
       $author = user_load( $authorID );
       
       $form['messages'][$message->id]['user_avatar'] = array(
           '#type' => 'value',
           '#value' => '<div class = "privatemsg_list_user_avatar">' . theme_avatar($author) . '</div>'  // theme the avatar and place in front of user-name, added class, 2008-05-27, sdsheridan
           );
       
   // end Add an avatar ...
           
       $form['messages'][$message->id]['user'] = array(
           '#type' => 'value',
           '#value' => '<div class = "privatemsg_list_user">' . theme('username', $message) . '</div>'  // added class, 2008-05-27, sdsheridan
           );
   

4. and then the function theme_privatemsg_message_table also in privatemsg.module as follows:
   

   function theme_privatemsg_message_table($form) {
     $rows = array();
   
     foreach (element_children($form) as $key) {
       if ($key != 'current_folder') {
         $row = array();
         $row[] = drupal_render($form[$key]['selected']);
         $row[] = $form[$key]['date']['#value'];
         $row[] = $form[$key]['user_avatar']['#value'];  // render the avatar in a separate cell, 9/6/2008 sdsheridan
         $row[] = $form[$key]['user']['#value'];
         $row[] = $form[$key]['subject']['#value'];
         $rows[] = $row;
       }
     }
   
     if (count($rows) == 0) {
       $rows[] = array(array('data' => t('No messages.'), 'colspan' => 4));
     }
   
     $header = array(
         NULL,
         t('Date'),
         ($form['current_folder']['#value'] == 1 ? t('To') : t('From')),
         "",  // Add null string to space headers properly, 9/6/2008 sdsheridan
         t('Subject'),
         );
   
     return theme('table', $header, $rows);
   }
   

This is working for me on my site. Still have to tackle the avatar in the actual message. That's next.

I'll have to noodle on it a bit. My default avatar is already small, so I don't have the issue you do in (b). Although I've not looked into the details of (a) yet, it strikes me that a bit of math and perhaps a couple of conditional statements are all that is needed...

@sdsheridan: great code! you seem to have put some work behind privatemsg on your own site. Would you be interested in doing some more official contribution to the project? drupal 6 version has a lot of features that need discussion and work and it would be great to bounce ideas off some one with experience.

Gosh, I'm flattered! I am kind of a newbie here, though, and to give credit where credit is due, I merely assembled other folks code to do what was needed. AND, I'm not a php programmer by ANY stretch of the imagination. I haven't been a programmer in about 15 years. That being said, I'm happy to offer my opinion for what it's worth... which may be not much... ;-)

I've commited some code changes to include author's avatar.

i dont really like the way it looks right now mostly due to the overall privatemsg inbox and messave theme and i dont have the will right now to re-theme. if some one wants to give it a try i'd be happy to mentor you to get drupal 5 version privatemsg theme the best it can.

for now please give me your feedback on the avatar display.

on the way it works is so: i'm using drupal default theme_user_picture and theme_username. so the size of the inbox author avatar entirely depends on your site user picture settings.

also it is up to you to provide default profile image if a user did not upload one.

go to your site admin url : admin/user/settings
all the way at the bottom of that page in the 'Default picture:' field paste this link for facebook default profile image: http://static.ak.fbcdn.net/pics/t_default.jpg

also notice i had some difficulties with the 5.x-2.x-dev branch, so i had to port everything to 5.x-3.x-dev branch. those of you that update from CVS will need to do a checkout on -r DRUPAL-5--3, those that download from the project page will need to wait until 5.x-3.x-dev snapshot appear on this page: http://drupal.org/node/3279/release

setting this issues to "needs review"

On my site, the user pics are actually relatively large, so you can see what the person looks like. That's why I wound up creating a separate function / facility for the avatars, as I use them elsewhere on the site and wanted smaller versions of the users' pics. In fact, I created the user_picture.tpl.php file to resize the displayed pics when not on the user profile page as follows:

/***
Customised formatting of the user picture on the site including an online/offline indicator.

Modified code from: function theme_user_picture($account) {
**/
  if (variable_get('user_pictures', 0)) {
    if ($account->picture && file_exists($account->picture)) {

      if (arg(0) == 'user' && is_numeric(arg(1))) { // If on user profile page       
        $picture = file_create_url($account->picture);
      }
      else { // somewhere else on the site - use small pic
        $info = image_get_info($account->picture);
        $newpicture = dirname($account->picture) . '/picture-' . $account->uid . "-avatar." . $info['extension'];
        
        if (!file_exists($newpicture) || (filectime($newpicture) < filectime($account->picture))) {
          image_scale($account->picture, $newpicture, 64, 64); 
          if (!file_exists($newpicture)) {
            $newpicture = $account->picture;
          }
        }
        
        $picture = file_create_url($newpicture);
      } 
    }
    else if (variable_get('user_picture_default', '')) {
      $picture = variable_get('user_picture_default', '');
    }

    if (isset($picture)) {
      $alt = t("@user's picture", array('@user' => $account->name ? $account->name : variable_get('anonymous', t('Anonymous'))));
      $picture = theme('image', $picture, $alt, $alt, '', FALSE);
      if (!empty($account->uid) && user_access('access user profiles')) {
        $picture = l($picture, "user/$account->uid", array('title' => t('View user profile.')), NULL, NULL, FALSE, TRUE);
      }
      
// code to show online/offline status
      $time_period = variable_get('user_block_seconds_online', 1200);
      $uid = $account->uid; // get the current userid for the avatar.
      $users = db_query("SELECT uid, name, access FROM {users} WHERE access >= %d AND uid = %s", time() - $time_period, $uid);
      $total_users = db_num_rows($users);

      if ($total_users == 1) {
        $output = '<span style="color: #00DD45; font-weight: bold">' . t('Online') . '</span>';
        }
      else {
        $output = '<span style="color: #AA4444">' . t('Offline') . '</span>';     
      }
      
      print '<div class="picture">' . $picture . $output . '</div>';
        
    }
  }

So to me, having a separate, smaller size is a nice thing. :-)

shawn

@sdsheridan: I've commited your code from #23.

I've included settings in admin/settings/privatemsg letting site admin to choose whether to show online status or not.

People using CVS can check it out from DRUPAL-5 revision.

People using package download from the project page will need to wait until 5.x-3.x-dev file is generated (happens once every 12 hours)

OK, added an avatar to the message itself by modifying the theme_privatemsg_view function as follows:

function theme_privatemsg_view($message) {
  global $user;

  if ($message) {
  
// add an avatar to the message display for either the sender or recipient, 2008-06-14 sdsheridan
    if ( $message->recipient == $user->uid ) {  // looking at a message sent to the current user, so theme the sender's avatar
        $authorID = array(
            'uid' => $message->uid
            );
        $avatarUser = user_load( $authorID );
    }
    else {  // looking at a message sent from the current user, so theme the recipient's avatar
        $recipientID = array(
            'uid' => $message->recipient
            );
        $avatarUser = user_load( $recipientID );
    }
    $avatar = '<div class = "privatemsg_avatar">' . theme_avatar($avatarUser) . '</div>';  // theme the avatar and place in front of user-name, added class, 2008-05-27, sdsheridan

    $body = $avatar;  // place the avatar at the front of the message
// end add an avatar, save for the change of '=' to '.=' on the following line    

    $body .= '
      <p><strong>'. t('From') .':</strong> '. theme('username', $message) .'<br />
      <strong>'. t('To') .':</strong> '. theme('username', user_load(array('uid' => $message->recipient))) .'<br />
      <strong>'. t('Subject') .':</strong> '.check_plain($message->subject) .'<br />
      <strong>'. t('Date') .':</strong> '. format_date($message->timestamp) .'</p>
       <div class="privatemsgbody">
      '. check_markup($message->message, $message->format, FALSE) .'</div>';
    $links = array();
    if ($message->recipient == $user->uid) {
      $author = user_load(array('uid' => $message->uid));
      if ($author->uid && (isset($author->privatemsg_allow) ? $author->privatemsg_allow : 1)) {
        $links['privatemsg_reply'] = array('title' => t('Reply to this message'), 'href' => 'privatemsg/reply/'. $message->id);
      }
      else {
        $links['privatemsg_noreply'] = array('title' => t('Sender does not accept replies'), 'href' => NULL);
      }
    }
    if ($message->recipient == $user->uid || variable_get('privatemsg_sent_status', 1)) {
      $links['privatemsg_delete'] = array('title' => t('Delete this message'), 'href' => 'privatemsg/delete/'. $message->id, 'attributes' => array('onclick' => "return confirm('". t('Are you sure to delete this message?') ."')"));
    }

    $links['privatemsg_list'] = array('title' => t('List messages'), 'href' => ($message->recipient == $user->uid && $message->folder) ? 'privatemsg/list/'. $message->folder : 'privatemsg');
    if ($message->id) {
      $body .= '<div class="links">'. theme('links', $links) .'</div>';
    }
  }
  else {
    drupal_set_message(t("Error: you can't read this message."), 'error');
    $body = '';
  }

  return $body;
}

Preliminary testing is working for me.

ah sorry about it, i commited code into a wrong branch.

the 5.x-3.x-dev code should be ready 12 hours from now. at that point you will be able to enjoy this feature.

Here's the privatemsg code from my machine. i'm attaching it here just in case if you dont wish to wait the 12 hours it takes for drupal.org to package the new release

@ drupalina: Sorry that was for the 1.8 version, which is the one I have on my site. Haven't upgraded yet. It's possible (I've not looked) that the functions in the new privatemsg.module are quite different, and then perhaps I've not helped at all... :(

Strange... I've read the code as a non-coder and I can't understand why my inbox shows the 'small pic' from the first else-clause and not the user picture that shows up elsewhere on the site. I mean, it's the same picture, but other dimensions.

I use imagecache and imagecache_profile to create square avatars. Any clues?

@truelove-nl : image resizing is hard coded into the d5 version. if some one want to write a patch for admin interface to let admin choose the size of privatemsg avatar, i would apply it.

@drupalina: i haven't looked at 1.8 code in a long while. dont update yet as there is no guarantee upgrade is possible.

i will need to play with it some more before update path is possible. once i can guarantee update path from 1.8 to 3.x-dev i will release an official 3.0 version for everyone to update to.

can some one give me status update if the issue at hand have been satisfied? or do we want to work some more on this ?

@ drupalina #32 Thank you, but where do I find the updated code for D5?

@drupalina: Yes, I can see that in the inbox... but i use the avatars elsewhere on my site, so it just made sense to have it all the same and use one code base. That being said, I suppose one could do some fancy theming of the avatar and displace the online/offline indicator... :-)

shawn

todo: add more css + divs to allow others to theme the messages

Has anyone got any (content-blurred/removed) pics of how facebook does its messaging?

As for general messaging, I do not think this module should support multiple template files - have one template file with every el;ement passed through to the template contained within it's own css class so that all the styling can be done via css.

i took some screenshots today. i'll edit them to remove vital information and hav them posted here for review.

Thanks for the image - it is similar to the setup in HEAD for drupal 6.

I gotta say, IMO the layout wastes too much space on the left hand side.

Hey Drupalina,

Were you able to figure out how to theme threaded messages more similarly to the way Facebook does it for the Drupal 5 version of this module?

bump. this is an interesting conversation.

I would very much like to see threaded messages looks more like facebook.

@drupalina - the threaded issue is definitely a killer! if messages were to take off on a site, an admin may decide to configure auto-archive or auto-delete as well (or some other admin imposed time or volume limit)

at that point, without the ability for those imposed limits to respect the message's position in a thread a user runs the risk of losing much dialogue *in context* - meaning that the train of thought is cut and hacked

by asking the module to see messages as threads only (either only message in the thread or whatever), then the imposed limits can in turn respect the 'most recent activity' within the thread and limit accordingly - meaning that if you and i have a thread going back and forth for three months, then anothe thread going for 1 year, the auto-archive or delete requests will ignore thread 2 (for one year) because it's "still going on" but will archive the older one (even though some messages from thread 2 are in the system at the same time)

this also opens the door to a more intuitive inbox, just like facebook or gmail or any common app - where most active and current threads rise to the top, and the old stuff moves on down the list...

I got the entire inbox to look pretty close to fb by hacking this module like there's no tomorrow (yeah I know that's not the proper way to do things...)

Anyway, I've attached my module file for those of you who want to look through it.

You will also need to add some css. All the associated css I could find is below. Some may be irrelevant but I'm pretty sure it covers everything.

Good Luck!

#privatemsg-cur-folder-form {
width: auto;
_width: 550px;
float: right;
display:none;
}

#privatemsg-cur-folder-form input{
display: none;
}

#privatemsg-list-form {
clear: both;
margin-left: auto;
margin-right: auto;
width: 55%;
}

table#privatemsg_message_table thead {
display: none;
}

#content_center table#privatemsg_message_table td.active{
background: none;
}

#content_center #privatemsg-cur-folder-form fieldset, #content_center #privatemsg-action-buttons fieldset{
width: auto;
}

.pm-inbox-avatar {
float: left;
width: 78px;
}

table.pm-view-table td.pm-from{
margin-right: 20px;
}

.pm-links {
border-bottom: thin solid lightgray;
padding-bottom: 23px;
clear: both;
padding-left: 30%;
}

.pm-view-table .title-cell {
display: none;
}

#privatemsg-new-form .pm-view-table .title-cell {
display: block;
}

.pm-view-table tr {
border: none;
}

.pm-body {
display: block;
margin-left: 31%;
width: 71%;
}

.pm-view-table {
width: 8%;
clear: both;
float: left;
margin-bottom: 28px;
margin-right: 25px;
}

#privatemsg-new-form .pm-view-table {
width: auto;
clear: left;
float: none;
margin-bottom: 0px;
}

.private-messages , #privatemsg-new-form{
margin-left: auto;
margin-right: auto;
width: 65%;
}

td.pm-date {
color: gray;
font-size: 8pt;
}

.pm-block-link {
margin-left: 0px;
}

@lukas2000- did you hack the whole thing up, or just the css? i'd love to see a screenshot

...and if possible, why not submit as a patch against head for an optional UI??

Screenshot is attached. I'll make a patch and submit it when I get a chance.

And yes, I hacked the module file up.

Looks great!

Good Day,

Noob here. I was wondering if you have detailed step-by-step tutorial on this? I want to try it out but I am a bit confused on modifying/hacking the module as you mentioned. The step you mentioned above privatemsg_list_form and theme_privatemsg_message_table, where do I add those codes? Do I remove the existing codes?

Thank you,

Mark

@drupalina sute, as long as we get a patch going.

Thanks Drupalina!

I think you can restore that panel by undoing this css mod:

#privatemsg-cur-folder-form input{
display: none;
}

Also, if you want to look at the areas where I modified the code, just search for the term "Lukas" in the module file I uploaded. When you're done with tweaking and restoring the things that come with this module by default you're welcome to patch this to HEAD. It's your baby now. :-)

Out of curiosity, which other modules are you people waiting for before considering a move to Drupal 6?

The drupal 6 version of this module does have a threading view which is closer to that of facebook (too close IMO as it also has some of the downsides), and also the listings display threads instead of messages.

The D6 version is only in HEAD, not even an alpha release, which is not something you want to be running in production. As to other modules, most people using this will have some sort of social networking sites and there are other modules lagging behind there. My list is about a month out of date but gives an idea of where we're at with SN in D6.

Michelle

thanks - I know that this module was not ready yet, but was interested to know what else.

@drupalina (and others involved in patching and modifying), regarding this persistent issue: http://drupal.org/node/170387#comment-1066384 (up above about threading and deletion)

have you seen the approach that PM Lite is taking? it's a hobby project from the guy behind ubercart, http://drupal.org/project/pm_lite

there are obviously some dramatic differences - the biggest of which is setting the message as a node - but by doing so, this allows for commenting to be enabled, and in turn, reply-to-reply-above could be disabled, resulting in a flat structure, which in turn would mean that a comment (in this case a 'message') could be safely deleted from within a thread (though it would disrupt flow of dialogue)

just some food for thought...

out of curiosity, i see that nearly 1000 people are now using head on d6!!! (via usage stats) - and only 8 bug reports against head and d6dev - is it time to release a beta perhaps? or are there *serious* lingering issues? i can't find any!!

About releasing a beta: #324380: Privatemsg: The road to Damascus lists all the "requirements".

We just need to add the missing features (which are more or less ready) and a tested upgrade path from drupal 5.

@nbz - thanks - it looks like it's getting quite close, like perhaps only weeks away!

It's there on line 230 of the module. Go to your user profile -> edit -> Notifications

lol. I don't think anyone has ever massacred my username in as many ways as you have, drupalina.

"UPDATE: found an answer to my own question finally. On the line 362 of Lucas2000's version of the module simply change 'Notifications' to default 'account'. Please correct me if I'm wrong, or if there's something else to do."

Yes, that should be sufficient.

When I get a chance, I'll work on getting combinined threads. Let me know if you figure it out in the mean time.

It would probably be best to do feature development in a new issue. I did create #323111: Message listing for threads is horrible in 5.x-3.0 for this problem - it has been closed as wontfix, but it would be a good place to do the work.

As for what needs to be done, you may get clues from #314366: Add paging to messages list.

In short, you need to add GROUP BY thread into the main listing query, and then unbreak the pager_query by feeding it a new function to count the number of messages (GROUP BY messes up the preg_replace inside pager_query).

EDIT: Or you can jump onto the Drupal 6 bandwaggon and help us get that ready for production use - it should more fit the bill of what people are trying to achieve here.

Hello Drupallers!

I am new in Drupal, but until now I really like it, I have learned a lot, I would like to have this functionality for pm 5.x-3.0 (GROUP BY thread) I have read the forums but it seems this is not done yet, I would like to work with some of u, I like team working and in that way I would have a guide to develop this functionality, so any help or guide on how to have this functionality is welcome.

Thanks in advance, and if anyone of u is working on the same, I would be glad to collaborate

Gepeto

It may be better for you to focus on the drupal 6 version. It already has this and more.

hmmm, but I am working with drupal 5 because there are many modules that I need that are not available for the 6th version, any ideas? I need also to be able to delete all the messages from the same thread (I mean a conversation).

Thx

Ok I did a trick, and I want to share it with u, in the configuration page I selected full thread view and in the function that list the messages in the inbox now I am checking the thread from the DB and unsetting the messages with the same thread except the last one (the most recent one) because they belong to the same conversation. I don't know if it is the right way but it is working as I want.

Now I am wondering how to create drafts, any ideas? My users need to compose a message and not send it but save it in a folder to send it later, can anyone guide me?

Thanks in advance Drupallers!

Hello drupalina!

As I wrote a did a trick, but for me is working, so I will explain u:

In the function privatemsg_list($uid = NULL) {}, search for the line:

$sql1 = "SELECT id, subject, p.timestamp, u.uid, u.name, newmsg, type FROM {privatemsg} p INNER JOIN {users} u ON ";

now add the thread to the query:

$sql1 = "SELECT id, subject, p.timestamp, u.uid, u.name, newmsg, type, thread FROM {privatemsg} p INNER JOIN {users} u ON ";

Now in the function that list the messages u can access to the thread by messages->thread:
function privatemsg_list_form($messages, $folders, $current_folder, $account) {}

Here in this function we have all the mesages, so we need to unset the messages that have the same thread because they belong to the same conversation and we dont want to show them, we will show just the last one, so:

Write the next somewhere in your foreach ($messages as $message) {
$current_thread = 0;
$last_thread = array();

$current_thread = $message->thread;
if(in_array($current_thread, $last_thread)){
unset($message);
continue;
}
$last_thread[] = $message->thread;

}

Now u will no have messages with the same thread listed, I hope it works for u, By the way do u know or have any idea how to create a dratf folder and save the messages there without sending them???

Na razie

ok here it goes...
function privatemsg_list_form($messages, $folders, $current_folder, $account) {
global $user;
$current_thread = 0;
$last_thread = array();

$form['account'] = array('#type' => 'value', '#value' => $account);

$form['messages'] = array(
'#theme' => 'privatemsg_message_table',
'#tree' => TRUE
);
$form['messages']['current_folder'] = array(
'#type' => 'value',
'#value' => $current_folder
);
foreach ($messages as $message) {
if ($current_folder != 1) {
$new = $message->newmsg;
$new_text = theme('mark');
$reply = $message->reply;
}
else {
$new = variable_get('privatemsg_sent_status', 1) ? $message->newmsg : 0;
$new_text = ' '. t('unread') .'';
$reply = 0;
}
$current_thread = $message->thread;
if(in_array($current_thread, $last_thread)){
unset($message);
continue;
}
$last_thread[] = $message->thread;
//$reply = $message->reply;
$form['messages'][$message->id]['message'] = array(
'#type' => 'value',
'#value' => $message,
);
//more code here...
}

The above is the wrong way to do this.

You need to use a GROUP BY in the query to do this properly, however that will break the paging unless there are more modifications made.

hmmm as i wrote before it is just a trick, and for now it is working, could u guide us how to implement the GROUP BY properly?

Lets move that to its own issue: #323111: Message listing for threads is horrible in 5.x-3.0

No guarantee if that will always work correctly, but it is the right (or atleast better) approach.

I'm closing old issues since Privatemsg for Drupal 5 is not maintained anymore. I suggest you switch to Drupal 6 if possible, many of the reported issues are probably already resolved there and if not, you're welcome to open a new issue.