[D7] Domain Access Entity

The git clone command in you description is wrong, use this one instead:
git clone http://git.drupal.org/sandbox/delta/1674202.git domain_access_entity

Automatic review

Check errors from http://ventral.org/pareview/httpgitdrupalorgsandboxdelta1674202git

Manual review

• domain_entity.module, line 494: duplicate array key 'display'.
• domain_entity.admin.inc, line 23, 52: typo 'wich'
• domain_entity.admin.inc, line 75: typo 'defaut'
• domain_entity.admin.inc, line 157: typo 'entites'

I can't go give you full review, because I'm not comfortable with DNS, but i noticed that your module doesn't contain documentation files and that you work on a master branch you should work on a version branch. See this.

Hey delta!

I just reviewed your projects and I have found some issues:

> Code-check failed: http://ventral.org/pareview/httpgitdrupalorgsandboxdelta1674202git
> As already mentioned: It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
> Please take a moment to make your README.txt follow the guidelines for in-project documentation.
> you don't have to specific "project" in the .info-file, since this is set automaticly
> Your directory-name must match your project_name. You should consider using "domain_entity" as directory-name.
> It's maybe just me, but it's really hard to read your code. You maybe should read the coding standards

I'm going to set the status to "needs work", at least because of the directory name (enabling the module only works, if you rename the folder)

Hey delta!

I just reviewed your projects and I have found some issues:

> Code-check failed: http://ventral.org/pareview/httpgitdrupalorgsandboxdelta1674202git
> As already mentioned: It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
> Please take a moment to make your README.txt follow the guidelines for in-project documentation.
> you don't have to specific "project" in the .info-file, since this is set automaticly
> Your directory-name must match your project_name. You should consider using "domain_entity" as directory-name.
> It's maybe just me, but it's really hard to read your code. You maybe should read the coding standards

I'm going to set the status to "needs work", at least because of the directory name (enabling the module only works, if you rename the folder)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I guess we should actualize this issue in accordance to rising amount of drupal commerce websites using subdomains.
What's the situation right now?
What kind of help needed?

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

manual review:

1. domain_entity_install(): do not juggle with module weights as that is very unreliable and prone to errors. Use hook_module_implements_alter() instead if you must run before another hook.
2. You use a lot of static db_select() calls, you might want to use db_query() instead? See http://drupal.org/node/310075
3. I think you should also delete the domain_entity_allowed_entity_types_backup variable on hook_uninstall()?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to stBorchert as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, delta!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

add review links