QueryPath filter

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Also have a look at the tips for a great project pageand the guidelines for in-project documentation.

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
Report: http://ventral.org/pareview/httpgitdrupalorgsandboxdolu1706658git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

Everything you need to know about projects and maintainership can be found in the documentation and it's subpages:
http://drupal.org/contribute/development

regards

# in .install, there is hook_install but no hook_uninstall , this should be there to uninstall schema
# "querypath_filter_encoding" this variable are set by this module? if so it should be deleted in hoo_uninstall

There is no need to install or uninstall schemas in drupal 7, that happens automatically

@patrickd , thanks , but to remove variable , we need to include hook_uninstall , right?

yes, variables still need to be uninstalled.

I really like your idea and I find this very useful.
That being said, I'd like to try reviewing your module, if you don't mind.

PAReview still has one complaint about coding standards: http://ventral.org/pareview/httpgitdrupalorgsandboxdolu1706658git-7x-1x

There is still a master branch, though you are not using it. You can remove it with these commands after setting the default branch to 7.x-1.x if you haven't already done so:

git branch -D master
git push origin :master

You should use $form['#attached'] here instead of drupal_add_css() and drupal_add_js(). This way, other modules can manipulate the attached css & js if they need to copy the form or alter it. As a note, for adding files you don't need to include the second parameter in drupal_add_ functions.

function querypath_filter_admin_rule_form($form, &$form_state, $rule = NULL) {
  // Add css and js files for this form.
  drupal_add_js(drupal_get_path('module', 'querypath_filter') . '/querypath_filter.js', 'file');
  drupal_add_css(drupal_get_path('module', 'querypath_filter') . '/querypath_filter.css', 'file');

• I think you should add a description to admin/config/content/querypath_filter, as every other menu entry in admin/config does.
• I think you should change the package from "Filters" to "QueryPath", as you are extending a large, multi-module package. http://drupal.org/node/542202#package
• It would be nice if you could wrap the "Add new rule" link in an unordered list with class action-links to remain consistent with the Drupal admin pages. Check out admin/structure/block for an example.
• Consider adding an API so other modules can create QueryPath filters by code.
• Consider adding a quick drupal_alter() to _querypath_filter_get_actions() so other modules can extend functionality.
• Consider advising the user that the order of filters matters. In a filtered HTML setting, QueryPath filter should run before the HTML filter, otherwise you may have disallowed HTML tags in your content due to this module's ability to insert HTML.
• Consider allowing different rules to be enabled per text format via filter settings.
• Do finish those filter tips. =) Something that just mentions all enabled rules will be applied would be nice.

I've tested this thoroughly and this module is safe and stable. After these minor changes, I think we can move it up to RTBC. =)

Sweet. This is rockin'.

If a few weeks pass without any attention from an administrator, you can participate in the review bonus program like I did.

Great job on this module!

Thanks for your contribution, dolu!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewers as well.