[D7] Taxonomy Pivot

welcome!

Automated stuff looks good, just delete the master branch:

git checkout 7.x-1.x
git branch -D master
git push origin :master

Make sure your README.txt follows the guidelines for in-project documentation.
It's the best if you keep your readme and project page in sync.

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Automated test looks good: http://ventral.org/pareview/httpgitdrupalorgsandboxmajestixx1705412git
But your code is not good:

1. I have an error after enabling the module: Fatal error: Call to undefined function filter_filter() in /.../sites/all/modules/taxonomy_pivot/taxonomy_pivot.module on line 36.
   Patch to fix
2. I have a notice on taxonomy-pivot page: Notice: Undefined index: triggering_element in function taxonomy_pivot_user_form() (line 163 in file /.../sites/all/modules/taxonomy_pivot/taxonomy_pivot.module)..
   Patch to fix
3. Module does not work for me. I have two taxonomy vocabularies but my taxonomy-pivot page looks like this
4. Please use theme_table for taxonomy_pivot.tpl.php
5. Please use jQuery.noConflict()
6. Please use db_select() in taxonomy_pivot.module (lines 81, 99, 643 and other)
7. Please do not use licensed images

http://drupal.org/licensing/faq/
Licensing FAQ

1. Remove the javascript alert(s).

2. You still have some code lisibility improvements todo: see http://ventral.org/pareview/httpgitdrupalorgsandboxmajestixx1705412git

3. Your git branches are not following naming conventions. Please read again http://drupal.org/node/1015226 to know more about it.

4. Try to use GPL image icons, here you have a list: http://groups.drupal.org/node/20380
If you cannot find what you want use: http://www.iconfinder.com and check the allowed for commercial use no link required. On the right side you will see information about the licence.

5. On line 297 you have an empty function. This should be removed.

6. You have an ajax call that points to an non-existent page, there is just a small problem about paths on line 11 of the taxonomy_pivot.js. There are several ways to get the url for sending the request. An example would be to get it on the Js file using: var pathname = window.location.pathname;
Another to create a hidden input in your .module file with the URL, and then get it as you made on line 10.

7. You shouldn't be using jQuery(document) ready.
Javascript should be loaded with:

(function ($) {
  Drupal.behaviors.initTaxonomyPivot = {
    attach: function (context) {
    /* Your code here */
    }
  }
}

this will avoid to have variables names already used by other modules.

8. On line 802 it would be nice to make a drupal_set_message() explaining to the user that she/he has to activate the module phpexcel.

9. On the CSS file line 7 you are using an image from an external website, this practice increases the page load time and is not really useful as the image can be copied inside the module folder.

10. Your install file can be deleted. The taxonomy_pivot_install() is empty and should be deleted.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Hello.

It may sound strange, but I cant confirm module functionality. For test case I have several Article nodes and they have 2 taxonomy vocabularies attached (Tags and Colors). I added some terms to vocabularies and after that to nodes. And as I understand, number of nodes which have terms must appear at taxonomy_pivot output. So I have only zero values. But there is definitely nodes with some taxonomy terms.

Also I'm not sure if translation files should be in git branch.
Code and code style seems Ok.

Thank you.

majestixx, I send you via email a profile info for account where I was testing your module.

Reviewing...

Remove print_r("wrong");, otherwise the code looks great. Seems to be a rather complex module, but no major issues found.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Seconded.

There's a few input errors reported at http://git.drupal.org/sandbox/majestixx/1705412.git. The raw $form_state['input'] is a security issue and printing the unsanitized node title, marking "needs work" for that. But otherwise this looks ready to go.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

You have a few issues reported here: http://pareview.sh/pareview/httpgitdrupalorgsandboxmajestixx1705412git.
You can remove the taxonomy_pivot_page_access() function, instead, in the menu hook, just set 'access arguments' => array('taxonomy pivot access'). And remove the 'access callback' line. The default is user_access(). So this way you're still calling the same user access check, without an additional function in the way.

Seems good otherwise!

----
Top Shelf Modules - Crafted, Curated, Contributed.

No further action is required, but the best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://pareview.sh is not enough.

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, majestixx!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.