delete message when user leaves Identifier blank
emmajane - August 28, 2007 - 04:43
| Project: | Flickr |
| Version: | 5.x-1.x-dev |
| Component: | flickr (main module) |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
When a user account is edited the message for $op=update is returned as:
%username's Flickr page has been deleted."
This is not correct. I have updated the message so that it is:
%username's Flickr page has been $op ed."
Patch is attached.
| Attachment | Size |
|---|---|
| flickr_0.patch | 729 bytes |
#1
i think you're correct that the message is in correct but i'm reluctant to just include variable directly... it won't be localized correctly.
#2
Whatever works best for all users is what should be done. The feedback for that entire section might need to be re-thought. It doesn't seem consistent in when/how it delivers messages...
#3
The original intent of the message was to make sure the user knew when their Flickr page was removed. I didn't think any other message was needed because Drupal already sets the message "The changes have been saved."
The proposed patch doesn't really make much sense because the message is only set when the flickr identifier field is blank. However, this did make me realize a bug. If the user didn't have a flickr page and they left the field blank, the "page deleted" message will still come up. My attached patch fixes that.
I haven't tested this.
#4
tested and ready, drewish can you committ?
#5
committed to DRUPAL-5
#6
Automatically closed -- issue fixed for two weeks with no activity.