Closed (fixed)
Project:
Drupal.org BDD
Component:
Feature/Scenarios
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
3 Aug 2012 at 17:24 UTC
Updated:
4 Jan 2014 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pradeeprkara commentedComment #2
pradeeprkara commentedThe queries form "Search for" text field is not yielding any expected results;
Is the search functionality broken here?
Comment #3
senpai commentedHmm, it might be. Please indicate the URL you're using, and the search term your entering, and the expected results, and I'll have the ApacheSolr Team take a look at this issue.
Comment #4
pradeeprkara commentedAs git6site user logins are not working because of the db reset(http://drupal.org/node/1720134), postponing this for now and will come back once it is fixed.
Comment #5
pradeeprkara commentedComment #6
kssundar commentedFYI: The user login issue is being followed here #1720134: Script the re-creation of all needed test user accounts and passwords for git6site
Comment #7
pradeeprkara commentedresuming
Comment #8
pradeeprkara commentedBelow is the search url which doesn't yield any results even though an issue exists with the name as that in the query string
http://git6site.devdrupal.org/project/user?text=Test+Project+Two&status%...
Use git vetted user login for testing
Comment #9
senpai commentedCheck and see if that expected content has been indexed by core search. (I've been told that it doesn't appear to be a solr thing)
Comment #10
pradeeprkara commentedComment #11
eliza411 commented@sdboyer: How often is cron being run on git6site (if ever)?
Regular site search won't index content until cron is run. The url pradeep pasted above indicates the test is checking to see that a newly created issue is found in the issue search, which seems like a meaningful test (at least I've had plenty of sites where cron quits running properly and content isn't indexed).
Once solution, assuming this is indeed the problem, could include running cron as a step in the test. The git vetted user won't be able to do this, though, so it's another situation where we either have sequentially dependent feature files or the test should be run by the 'admin test' user. afaik, the issue search functionality should be validly testable by either user.
Ideally, one might also like to validate that site search indexing is being run on the expected schedule and behaving as expected. Waiting for 1 hour or whatever the schedule is on a test seems fairly silly, though.
Thoughts?
Comment #12
sdboyer commentedthe issue here is probably that, due to running out of space on the db server, we removed the search index for issues (which is still in the db, not solr). that saved 11GB. dww brought this problem up, and i imagine it's what we're seeing now.
i'm gonna leave this as postponed for now, as reincluding those tables in the db dump could easily result in overfilling our db servers again.
Comment #13
sdboyer commentedoh, and it looks like cron wasn't running at all on git6, not since the migration. i've turned it back on, in 15 minute increments.
Comment #14
pradeeprkara commentedSince the inputs from "Search for" field only is not giving results, I have commented the step for the same.
#the below step doesn't work for git6site
#And I fill in "Search for" with Project Name
Attached is the patch. Once the search issue is fixed, will uncomment and roll out another one.
Comment #15
eliza411 commentedLooks like one spot got missed or depends on something not yet committed in features/project/your_projects.feature
Comment #16
pradeeprkara commentedtagging for sprint 4
Comment #17
pradeeprkara commentedassigning to myself
Comment #18
pradeeprkara commentedThe above error (#15), is probably due to the updates in Branch,
Recreated and attached the patch.
Comment #19
eliza411 commentedAdd the actual business value and the right type of user:
This should be replaced with
For every following scenario, all of the following should be deleted:
and the subsequent step should begin with When (unless it's an oddball one where you're just verifying all the data is present)
Comment #20
pradeeprkara commentedUpdated the features as suggested. As there is no corresponding action involved, I have removed When from some of the scenarios(Eg: Scenario: Check the links in Project Table)
Also splitted some of the scenarios which had multiple actions to keep it simple.
Eg:
Scenario: Check View link from Issue Links column for Projects
and
Scenario: Check Search link from Issue Links column for Projects
You can find below the modified features, once confirmed, will roll out a patch.
Commit log: ded9c10
Comment #21
eliza411 commentedI think the more granular steps are appropriate here.
On a content level (correct me if I'm wrong), I'm seeing that these scenarios assume that data exists, but that data won't upon a fresh copy of the database is put in place (which will happen every time code is integrated) so this will fail in a continuous integration environment.
I've opened a meta issue on the topic #1742962: [meta] Create data for tests
Comment #22
eliza411 commentedSetting to needs work / postponed may be appropriate, too.
Comment #23
pradeeprkara commentedPostponing, will resume once #1742962: [meta] Create data for tests is resolved
Comment #24
pradeeprkara commentedcopied the steps from patch to dev
Comment #25
eliza411 commentedSince it appears that we'll be handling data set up in the background steps, would you revisit this and see if you can finish it now?
Comment #26
pradeeprkara commentedsure, I will put the necessary steps to have the test data ready in the initial scenarios.
Tagging.
Comment #27
pradeeprkara commentedAdded scenarios to create sandbox project, project and project issue.
As the issue title was hard coded in your_projects_feed.feature, merged scenario to your_projects.feature so that internally it will look for the test issue title.
As issue search is fine now, incorporated corresponding steps as well.
Please see the commit: 9b6efa6
@important
Now we experience a timeout issue for /project/user, probably due to the huge number of test projects appear on that page?
Comment #28
eliza411 commentedIf you want to delete a bunch of those with the admin test account to see if it helps, that's the best I can suggest until we're getting more regular database refreshes. We don't really have the access we'd need to efficiently delete them after tests run, I don't think.
Comment #30
eliza411 commentedIf you can have these clean up after themselves, that would be ideal; if access is a problem, then don't bother.
In the meantime, we're getting three failures:
Comment #31
pradeeprkara commentedThe scenarios except "Check Issue search" work for me. This failure is due to the issue mentioned in Comment #2. This was working fine until the last db refresh; tagged the scenario as @wip for now.
Added @clean_data tag(to delete test data)
The commit: a190921
Comment #32
eliza411 commentedI spent some time on the broken scenario today, and it seems to me that there's a fundamental problem with it:
Instead of filling in "Search for" with the project name, I think you should be searching on the title of an issue (or text within an issue).
Comment #33
pradeeprkara commentedtagging
Comment #34
pradeeprkara commentedIts fine when search is being performed with issue name.
Changed steps accordingly.
But the test issue created afresh is not being captured and it takes nearly 15 minutes to get it indexed.
Committed the changes keeping @wip tag.
The commits: 8e2a6ab, 6e717ce
Comment #35
eliza411 commentedhttp://drupalcode.org/project/doobie.git/commit/33c3922
http://drupal.org/node/1712286
Comment #36.0
(not verified) commentededited description