Download & Extend
Feeds » Issues

feeds_importer "config" column to short - change size to big

Posted by theduke on August 6, 2012 at 11:22am
Project:Feeds
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:major
Assigned:Unassigned
Status:patch (to be ported)

Issue Summary

I have an import with quite a lot of fields mapped.

When i try to add an additional mapping field I get the error "Data truncated. Data too long for column..."

Solution is to set the config column size to big.
Attaching patch in first comment.

Login or register to post comments

Comments

#1

Posted by theduke on August 6, 2012 at 11:32am
Priority:normal» major
Status:active» needs review

Patch.

Also changing priority to major since this completely breaks functionality once reaching a certain config size.

AttachmentSizeStatusTest resultOperations
feeds-config-column-size-1715124-1.patch851 bytesIgnored: Check issue status.NoneNone

#2

Posted by theduke on August 6, 2012 at 11:34am

Whoops, missing comma...

AttachmentSizeStatusTest resultOperations
feeds-config-column-size-1715124-1.patch852 bytesIgnored: Check issue status.NoneNone

#3

Posted by twistor on August 8, 2012 at 5:20am
Status:needs review» needs work

hook_schema needs to be updated as well. Also, while we're at it, let's change from text to blob. Would it make more sense to split the configs into three separate columns? How many mappings do you have?

#4

Posted by theduke on August 10, 2012 at 1:13pm
Status:needs work» needs review

I don't think it's necessary to split into 3 columns.
MySQL longblob/longtext columns can hold 4GB of data.
That should suffice.

I'm attaching a patch that changes both config fields to blob.

It's probably not necessary to change the source config to big,
but let's make them consistent.

AttachmentSizeStatusTest resultOperations
feeds-config-columns-1715124-4.patch1.79 KBIgnored: Check issue status.NoneNone

#5

Posted by theduke on August 26, 2012 at 7:19am

Are the changes ok for you twistor?

#6

Posted by stylesuxx on August 28, 2012 at 3:31pm

As stated (and closed as duplicate) here: http://drupal.org/node/1736438 I'd like to see this changed too :-)

#7

Posted by theduke on September 18, 2012 at 3:35pm

Bumping...

#8

Posted by twistor on September 26, 2012 at 2:57am
Status:needs review» patch (to be ported)

Comitted to 7.x
http://drupalcode.org/project/feeds.git/commit/ceb98dd

#9

Posted by twistor on September 26, 2012 at 2:58am

How many mappings do you have?

#10

Posted by stylesuxx on September 28, 2012 at 8:43am

About 320.

#11

Posted by lyricnz on November 2, 2012 at 10:29am

It seems db_change_field() didn't work for SQL server - #1828950: Update to alpha7 database update fails on MSSQL

nobody click here