Does og_vocab need to own its Vocabularies?

Attached is a patch that keeps og_vocab from taking ownership of the vocabularies. There should be entries in the og_vocab table that make it unnecessary to set the vocabulary's module name.

Seems like I must be missing something?

set to "code needs review"

Yes, I agree that since these are group-specific vocabs, it makes sense for og_vocab to mark them as such.

hook_term_path() is the only hook called by taxonomy that targets a specific module, as opposed to allowing all modules to return something. taxonomy_term_path() is the only function that calls module_invoke:

function taxonomy_term_path($term) {
  $vocabulary = taxonomy_get_vocabulary($term->vid);
  if ($vocabulary->module != 'taxonomy' && $path = module_invoke($vocabulary->module, 'term_path', $term)) {
    return $path;
  }
  return 'taxonomy/term/'. $term->tid;
}

...and it's the only place where the 'module' field in the vocabulary table is used (by taxonomy.module).

Nodeorder implements hook_term_path() so that taxonomy terms, when gathered via phptemplate's call to $taxonomy = taxonomy_link('taxonomy terms', $node);, link to nodeorder/term/TID instead of taxonomy/term/TID.

There's a lot going on here:

1. phptemplate.engine calls taxonomy_link directly with 'taxonomy terms' as the type. hook_link says only lists 'node' and 'comment' as possible values for type, which leads me to believe that this dependency between phptemplate.engine and taxonomy was meant as a short-term fix for something.
2. og_vocab sets the module in its vocabularies, but doesn't take advantage of the one thing that taxonomy uses it for.
3. taxonomy's method of calling hook_term_path is inconsistent with the rest of the hook calls that are made by the module. A possible solution for this would be to call module_invoke_all('term_path' ...) or something like it, and take the first or last returned value. In my case, where I want og_vocab and nodeorder to work together, this would just work out-of-the-box because og_vocab doesn't implement hook_term_path.

I think I can work around this by branching nodeorder, getting rid of my hook_term_path implementation, and, instead, implement hook_link_alter. I don't have a problem with this, if that's what you think is the best solution. It just seems like this is pointing out some minor inconsistencies in taxonomy's handling of generating term paths, and a possibly unnecessary dependency between phptemplate and taxonomy.

Thanks for taking the time to respond, Moshe.

Marc

The only taxonomy code that cares about the module field in the vocabulary table is in taxonomy_term_path(). A quick search for taxonomy_term_path gives a decent sized list of issues related to this.

Seems like the new best way to deal with this is probably to call drupal_alter() when generating taxonomy links and get rid of the module field in the vocabulary table.