Likable Clean Theme is a clean, multi-column Drupal 7 theme with many block regions and a slideshow ready for use.

project page

katrin@git.drupal.org:sandbox/katrin/1717352.git

Live Demo

Likable Clean Theme

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

serjas’s picture

serjas commented

Manual review
# remove LICENCE.txt
# create branch 7.x
# Remove version from .info

installed the theme, working fine. some suggestions
# text is hard to read. try change color to #333
# in admin/appearance, some css issues with links under theme

and how to make menu as drop down? which region?

katrin’s picture

katrin commented

Hi serjas,
thanks for your review.

# remove LICENCE.txt - removed LICENCE.txt
# create branch 7.x - Where can I read instruction how to create branch 7.x?
# Remove version from .info - removed version from .info

# text is hard to read. try change color to #333 - changed color to #333
# in admin/appearance, some css issues with links under theme - What Issues?

Don't place main menu into the region. Check the 'Show as expanded' option for parent menu items on admin/structure/menu/manage/main-menu only if you want main menu as drop down.

katrin’s picture

katrin commented

Created branch 7.x-1.x

git checkout master
git checkout -b 7.x-1.x
git push origin 7.x-1.x

What I must do next?

katrin’s picture

katrin commented

Hi klausi,
ok, I will try to help you if I can :-)

D4Ko’s picture

D4Ko commented
Status: Needs review » Needs work

Please take a moment to make your project page follow tips for a great project page.

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxkatrin1717352git

katrin’s picture

katrin commented
Status: Needs work » Needs review

Thanks DaKo,
errors fixed - http://ventral.org/pareview/httpgitdrupalorgsandboxkatrin1717352git.

serjas’s picture

serjas commented
Status: Needs review » Reviewed & tested by the community
katrin’s picture

katrin commented
Assigned: katrin » Unassigned
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » klausi
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: klausi » Unassigned
Status: Reviewed & tested by the community » Fixed

manual review:

  1. "changed info" is not a useful git commit message, see http://drupal.org/node/52287 to be more descriptive.
  2. there is an empty folder in your repository with the name "1717352", please remove it.
  3. superfish.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org. This is not a blocker as the file is GPL-compatible.

Thanks for your contribution, katrin!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

katrin’s picture

katrin commented

Hi klausi,

Thank you very much for your review and advices that you gave me.
I will change the things you've mentioned.
Thank you once more for your time :)

Best Regards!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.