Enable message type selection

SInce this touches on it, t() shouldn't wrap variables.

t() shouldn't wrap variables.

I believe that requirement is no longer relevant.

Re-rolled so that it applies to 7.x-1.x-dev.

In spite of what the docs say, I really do think that it's fine to do t($foo) if $foo is some complete string entered by site administrators.

t($foo) is a no-no. The problem is twofold:

• It lies to drupal.org's package handling / string translation parsing mechanism. The drupal.org localization infrastructure will think that you need the string "$foo" translated.
• Despite the above, it may still work in practice (because of how the t() function actually operates). However, as soon as you change the string, all translations will be lost (because the translation is keyed by the string itself); it'll leave the existing translations behind in the localization table as cruft, and you'll have to re-enter text.

To properly translate Drupal variables, you're looking for this kind of thing. Where you're registering your variable with the Variable module and i18n_variable is taking care of things behind the scenes for you (so you can variable_get('your_variable'); and it'll return the localized value for you, without having to run it through anything like t()). Something like this:

/**
 * Implements hook_variable_info().
 */
function r4032login_variable_info() {
  $variables['r4032login_access_denied_message'] = array(
    // Variable definition here, and then also:
    'localize' => TRUE,
  );
  return $variables;
}

Note that this does not create a dependency on Variable, or i18n. It just allows sites that have a need for variable translation to localize your variable (because they would have those modules installed and enabled and know how to use them already).

OK, awesome, thanks for the explanation. It seems like that can be a followup in its own issue (indeed it is at #1138562: Integrate with i18n_variable) and we can just go ahead here with #3.

#3 still makes sense and still applies.

Any reason not to commit it?

8.x got started on this project

working on adding this to the 8.x-1.x branch.