libs are always loaded even if disabled
tangent - September 3, 2007 - 04:07
| Project: | Markdown with SmartyPants |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
The _marksmarty_process() function always loads both markdown and smartypants includes instead of only loading them if those filters are enabled. For obvious performance benefits they should be required inside the feature check.
The attached patch does that and a whitespace fix snuck in there also.
| Attachment | Size |
|---|---|
| marksmarty.module_1.patch | 1.27 KB |
#1
why would the process hook get called for filters which are inactive? i haven't researched this but i bet you have.
#2
The issue is valid, and the patch ready to be committed in my eyes. I've implemented it in my patch as well, see http://drupal.org/node/220156 .
#3
fixed in HEAD
#4
committed to DRUPAL-5 as well.
#5
Automatically closed -- issue fixed for two weeks with no activity.