page titles are broken when outside the active menu or on a callback

I think this relatively simple fix gives us pretty much all that we want.

Also fixes some calback titles that were broken.

this patch is functionally identical, but chx likes the use of an array index better then end()/reset()

Note- the page title for by-module is right if it's still in the Navigation menu, just not if it's moved. So, this patch doesn't catch this case - basically local tasks may need to set the page tittle.

ok - here's a possibly more robust fix - should get the right title (i.e. the title of the root page) for local tasks even outside the active menu.

needs a little more work - found a path where this breaks: admin/settings/filters/1/configure

I think this is because the tab_root invludes a '%' wildcard.

a general explanation of the logic in the patch:

If you deconvolute the logic, on a normal page (i.e. in the active menu) it should work as before

The last item in the active train is used to set the page title. So when we're outside the active, or on a callback, there may be no active trail. So, to fix this, we append the current item to the active trail if it's not there. For tabs we want the root item, rather than the tab itself.

The previous iteration always did $item['href'] = $item['tab_root']; and this one doesn't'; now I'm assigning the whole root item.

ok - well this still isn't quite right for the filter pages - but that's because of a bug in filter module - it doesn't declare a title attribute nor set the title.

Otherwise, I think this is closer to correct.

Greatly expanded code comments - also noticed an error - I put 'tab_parent', rather than 'tab_root' in the explode(). These will be the same for top-level tabs, but not for sub-tabs.

Also, there are a number of pages where the root path has a wildcard where the titles are not quite right in addition to the filter module, such as: admin/content/taxonomy/1/add/term

Basically this needs to be handled in separate patches for various paths in 1 of two ways: as menu module does with a title callback, or as node module does by calling drupal_set_title() separately for node/% and node/%/edit.

@Dries - are the code comments now sufficient?

@Dries - we can already have dynamic titles using the title callback (see menu module for the one example so far in core - the string "(overview)" is added to the menu name to generate the title). This may be a more effective way to handle items were the root has a wildcard in the path (e.g. different filters with different names) rather than patching each tab's page callback to have a drupal_set_title().