Context Node Template

Module works as advertised. I confirmed on a clean install that the context is correctly triggered based on $node->template, which is set by the node_page module.

Here's some issues:

• The file context_node_template.info has two blank lines at the end instead of one.
• On line 5 of context_node_template.module your comment exceeds 80 characters, and does not accurately explain the contents of the file.
• context_node_template.module needs to end in a blank line. Take the extra one from the .info file ;)
• The @file description in context_node_template_context_condition.inc claims the condition is based on NID. Should be changed to "node template" or something more descriptive/accurate.
• The documentation of the method context_node_template_context_condition::match() has the incorrect parameters listed.

Hello

I just checked on the automated project review and you still have some errors and warnings: http://ventral.org/pareview/httpgitdrupalorgsandboxzhiqiangqiu1728072git

Hello,

I think you also have a branch for Drupal 7.x-1.x version, I think you may also inform about it in the issue summery.

Please put git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/zhiqiang.qiu/1728072.git context_node_template as the git command, as the one which you have kept is for you only, and it requires your profile password, reviewers might feel lazy and skip reviewing your project.

Thanks

Review of 7.x branch:

You have named the class functions incorrectly in context_node_template_context_condition.inc, the module doesn't work.

conditionForm should be condition_form
conditionformsubmit should be condition_form_submit
optionsform should be options_form
optionsFormSubmit should be options_form_submit

Otherwise it seems to be working.

Took a quick view of your project.

• Installation instruction can be put in INSTALL.txt file. It is fine to put it in README.txt file. But it helps if you put them separately.
• In .info file, put description in second line of the document. There is no need to put quotation around description. Module description in the info file should be as short and descriptive as possible. Common pattern "Changes default pagination to 'x of yy' " od somethins along the lines.

You still have errors in your code

http://ventral.org/pareview/httpgitdrupalorgsandboxzhiqiangqiu1728072git

That minor coding standard issues are surely no application blockers, anything else? Please do a manual review.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

I've done a manual review and it looks fine to me.

The only suggestion i have is to consider being a little more detailed with your commit messages in the future.

Only possible thing to consider is that this is barely over the "minimum length" requirement of 120 lines/5 functions. I have no idea where we are as a community on that debate but i am going to RTBC this and just have this as a note for an admin to make a call on.

Thanks for your contribution, zhiqiang!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Good job guys, been following.