Download & Extend
Simplenews » Issues

Translations of time span collides with other translations

Posted by lund.mikkel on August 14, 2012 at 1:36pm
Project:Simplenews
Version:7.x-1.x-dev
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The translation of some time spans collide with translations using format_plural:

'#options' => array(
      0 => t('Immediate'),
      1 => t('1 day'),
      7 => t('1 week'),
      14 => t('2 weeks'),
)

Due to the format_plural of both '1 day' and '1 week' the translations already exist. I suggest changing the code to:

'#options' => array(
      0 => t('Immediate'),
      1 => format_plural(1, '1 day', '@count days'),
      7 => format_plural(1, '1 week', '@count weeks'),
      14 => format_plural(2, '1 week', '@count weeks'),
)

I'll try to submit a patch in the comments...

Login or register to post comments

Comments

#1

Posted by lund.mikkel on August 14, 2012 at 1:38pm

Patch

AttachmentSizeStatusTest resultOperations
simplenews-format_plural-1730008-1.patch956 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 1,812 pass(es).View details

#2

Posted by Berdir on September 8, 2012 at 9:27am
Status:needs review» fixed

Thanks, commited and pushed.

#3

Posted by System Message on September 22, 2012 at 9:31am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.