The JS in Drupal.behaviors.flagLinkOptions can probably now be done in Form API.

CommentFileSizeAuthor
#7 1730164-7.flag_.link-options-states.patch3.98 KBjoachim
#4 1730164.flag_.link-options-states.patch3.01 KBjoachim

Comments

joachim’s picture

joachim commented
Issue tags: +Novice

Tagging.

joachim’s picture

joachim commented
Issue tags: +JavaScript

Tagging.

joachim’s picture

joachim commented

#1875854: remove after_build for radio button descriptions needs tackling first.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1730164.flag_.link-options-states.patch3.01 KB

Not actually as much as a code saving as I hoped, as we should really be nice and to the legwork for any other link type modules.

Still, I prefer to have code that uses FormAPI rather than raw JS: keeps everything in the same place and easier to read.

socketwench’s picture

socketwench commented

Hm. Okay, the automated tests run cleanly, but I suspect this requires manual testing.

joachim’s picture

joachim commented

Yup, Simpletest knows nothing about JS.

joachim’s picture

joachim commented
StatusFileSize
new 1730164-7.flag_.link-options-states.patch3.98 KB

Updated patch -- the intro text wasn't getting hidden.

@socketwench: got time to give this a very quick look before I commit?

socketwench’s picture

socketwench commented
Status: Needs review » Reviewed & tested by the community

Looks good. Confirmed with manual testing.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Committed.

Automatically closed -- issue fixed for 2 weeks with no activity.