Closed (fixed)
Project:
Hierarchical Select
Version:
5.x-2.0-rc1
Component:
Code
Priority:
Critical
Category:
Feature request
Assigned:
Reporter:
Created:
4 Sep 2007 at 20:07 UTC
Updated:
29 Jan 2008 at 23:36 UTC
Congratulations!!
It was already hour that somebody made a module like this. Thank you.
By the way, when using it in VIEWS the "Optional" option from the exposed filters doesn't work. When seeing the VIEW "All" doesn't appear in the lists of the exposed filters. And the labels of the exposed filters also disappear.
Comments
Comment #1
wim leersHm, you're right about the labels. In my use cases this wasn't necessary yet, but it's of course something that should be supported.
And indeed, "all" and "none" are currently not available. You always have to select something. That's "by design" currently. That's something I'd like to change too.
Patches are welcome :)
Comment #2
armand0 commentedHas nobody been able to make that it is Optional? that is to say that shows an option "All" in the heads of the lists.
I have attempted it. But it seems that my knowledge of Drupal is not enough. Although I have some other places, only made with PHP and Ajax in those that I have made it. But here I don't find how to make it.
I hope somebody can get it.
Comment #3
wim leersComment #4
wim leersAn "all" option won't be added. A "none" option will. "All" is the equivalent of a select with the #multiple property enabled and then selecting everything, so that's what should happen.
Comment #5
wim leersI just have to rewrite the rendering function at this point. The "required" property of form elements is already being passed through (that's not yet committed though).
Comment #6
wim leersCommitted. Please give the 5.x-dev tarball a try and report back how it works.
Comment #7
armand0 commentedI don't know. I see a lot of use to an option
<all>. For example a vocabulary of cars:Vocabulary
-cars
--Ford
---Thunderbird
---Fussion
--Nissan
---Hikari
---Tsuru
Now the user should choose the mark of the car and a model should select. To my I would like the user to only choose the mark of the car and to opt for All his models, or an X model.
But I don't see any use to an
<none>option. I am already limiting that is not shown that don't want from the filters of the view.And the user, continuing with the example, it won't look for All the cars that are not a Tsuru of Nissan.
Comment #8
wim leersAn "all" option is only applicable to selects with the "multiple" property enabled, which currently isn't supported at all. First there has to be support for that.
The "none" option is useful when you don't want to select *anything*, because now you *always* have to select something.
Comment #9
mark matuschka commentedThe "all" option is necessary in exposed view filters when the filter is optional. See functionality without the module installed. Also it's important to be able to filter by a parent category only, ie. including "all" sub-categories.
Great module by the way. Some teething issues expected early on but you have made a fabulous start.
Comment #10
mark matuschka commentedActually to be consistent with the way exposed views filters work, the top item in the *parent* list should be "all" (as I said in #9) but the top item in *subsequent* levels should be "none" (different to what I said in #9).
In views filters language, "all" is really "any". Existing views filters functionality includes "all" for parent level and "none" for sub-levels. It would be nice to have "all" *and* "none" at the sub-level, but "all" at sub-level is not currently provided by views filters.
Didn't mean it to sound this complex.
Comment #11
wim leersHierarchical Select currently doesn't support selecting multiple items. So it doesn't make sense to select all of them. First we need multiple select support. In fact, the "all" option could be part of the same patch.
Comment #12
(not verified) commentedComment #13
Encarte commentedI hope I'm following the right procedures by reopening this issue (I apologize if I'm not). The Hierarchical Select 2 now supports multiple select and the «all» option (actually «any») is essential for the use of exposed filters (without it the vocabularies became mandatory and the search returns empty if no tag is selected).
I believe this module has a great potential and it could have a very wide use, but any site that uses exposed filters in views needs this «all» option or, at least some way to disable Hierarchical Select when exposed filters are being used (enabling it only in node edition and in views with no exposed filters).
Best regards.
Comment #14
Encarte commentedComment #15
wim leersAgreed. Completely forgot about this – because I haven't tested HS 2's integration with Views yet.
You will get the ability to set it to an arbitrary name (all/any, whatever you prefer).
Not sure I'll have time for this any time soon though. Sponsoring would allow me to give it a higher priority.
Comment #16
wim leersOh and please start a *new* issue. This was the issue for the ability to have optional form items: http://drupal.org/cvs?commit=82347.
Thanks.
Comment #17
wim leers