Clean up code

Looks great!

I've always wondered about " // Load the modes in here instead of _init() toprofit from caching, ...", I saw you simply just removed it.

Moved $_make_translatable out from the loop and removed $_make_translatable.

Should "mostrecent", "maxchoices", "uselist", "showvotes" be renamed?

One liner?:

    if ($vote->uid == 0) {
      // Anonymous user.
      $key = $vote->hostname;
    }
    else {
      // Logged-in user.
      $key = $vote->uid;
    }

What to you say about re-ordering functions? I guess it would mess up this patch to much but is it something we want to do?

Maybe it's less than I remember, but for example hook_load, hook_view, hook_delete should come after eachother. Also there is sort of a standar way for listing funcions, hook_menu, hook_perm early etc. I'll take a look at it later.

Here is a version that moves around functions a bit (mostly hook functions). Let me know what you think.

Another thing I though about was our use of "tab" in some function names. Usually "page" is used to refer to a, well..., page.

I did a search for "tab" in core (I wasn't sure either) and it wasn't used for function names.

advpoll_form.js need to be updated to the new IDs.

Are you working on the update path ? ;)

Sorry, I didn't bother checking the source. For some reason update_5 was taken (probably some old testing), I bumped it up to 6. Testing now.

Yes of course, good tip. I should have read that upgrade path though, really impressive work!

Last bug?:
* Startdate turns into "1970-01-01 00:02:07 +0000" when editing a poll.

I also found that "Clear electoral list" doesn't do anything from what I can see (not caused by this patch, so it can wait).

Did some changes to advpoll.install

* changed int(10) to just int
* show_votes now has NOT NULL default '1'
* changed integer to int in upgrade path

RTBC :)