Is there a way to disable forward in comments in 4.7?

Thank you.

CommentFileSizeAuthor
#5 forward.module.4.7.diff918 bytesdennys
#2 forward.module.rej_.info829 bytesskyl1ne
#1 forward.module.diff1.71 KBdennys

Comments

dennys’s picture

dennys commented
Version: 4.7.x-1.x-dev » 5.x-1.5
Status: Active » Needs review
StatusFileSize
new forward.module.diff1.71 KB

Please try this patch (for 1.5). I add a new option "Show Forward on comments", if it's enabled then the link/form will appear on comments.

This patch includes my previous 2 patches 168442 and 168376, if you don't need them, please remove it.

skyl1ne’s picture

skyl1ne commented
Version: 5.x-1.5 » 4.7.x-1.x-dev
StatusFileSize
new forward.module.rej_.info829 bytes

Thank you for the patch. when I applied it, I received the following errors.

===============
Hunk #3 failed at 535
Hunk #4 failed at 566

Hunk 5 succeeded at 733 (offset -5 lines)

2 out of 5 Hunks FAILED -- saving rejects to file forward.module.rej file.
================

I have attached the forward.module.rej

Also, when I enabled the forward module, I received:

Parse error: syntax error, unexpected ';', expecting ')' in /modules/forward/forward.module on line 119

Finally, when I edited the forward.module and added manually:

$form['forward_options']['forward_show_comment'] = array(
    '#type' => 'checkbox',
    '#title' => t('Show Forward on comments'),
    '#return_value' => 1,
    '#default_value' => variable_get('forward_show_comment', false),
    '#description' => t('If checked, the link/form will appear on comments'),
  );

There were no errors, but "forward this comment" still appeared.

Any help would be appreciated.

Thank you.

dennys’s picture

dennys commented

What version you use ? I use 1.5.

skyl1ne’s picture

skyl1ne commented

I am using forward.module,v 1.11.2.24 2007/07/09 on Drupal 4.7x.

Thank you.

dennys’s picture

dennys commented
StatusFileSize
new forward.module.4.7.diff918 bytes

Sorry, I don't have 4.7 environment. I download your version and try to modify it, could you help to test it ?

skyl1ne’s picture

skyl1ne commented

Yes, I would be glad to help test it.

seanr’s picture

seanr
he/him
commented
Category: support » feature
Status: Needs review » Active

Please try 4.7.x-dev after the server updates the tarball (or get it from CVS)

dennys’s picture

dennys commented
Version: 4.7.x-1.x-dev » 5.x-1.x-dev

Could you consider to add this patch in 5.x too ? thanks.

seanr’s picture

seanr
he/him
commented
Status: Active » Fixed

Done in CVS, though it probably won't show up in 5.x-1.x-dev for a while as the server only repackages the dev tarballs twice a day.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.