Hi,

I've tested this with both internet explorer and firerfox and it appears that fivestar falls back to the non-fancy 'default' and much less pretty version, I think this is an issue with my theme, as it appears correctly on the administrative settings page (which uses garland) while my site uses a custom theme. Though it does print out $scripts correctly, which was what a thorough search of the forums suggested could be the issue.

I've tried cutting back on javascript to see if conflicts were the issue, but nothing has had any impact.

Thanks so much for taking the time to read this, and any help would be appreciated. Will post back if I figure out a fix in the meantime.

Regards,
Peter Sandersen

Comments

kmv’s picture

Version: 5.x-1.7 » 5.x-1.8

I have just started seeing this too. It happened right after I upgraded to drupal 5.3 (from 5.2) and updated a bunch of modules (including taking Fivestar up to 1.8).

I have noticed that /fivestar/preview/0 (say) 404s.

Does this ring any bells for anyone?

quicksketch’s picture

That's no good! Could you try the following things and let me know if any of them solve the problem?

- Run update.php
- Clear your cache with devel module (or TRUNCATE cache and cache_menu).
- Check the admin/user/access and make sure permissions are set for fivestar

There might be some other items I've left out. I haven't seen this behavior though, so it might be hard to track down. Please continue to post any discoveries you might have about the cause. Thanks!

fossie’s picture

Also running drupal 5.3 with version fivestar 1.8 and some people see also a degradation to non-javascript browsers even if javascript is enabled and working. I personally never saw the issue, so can't trace the problem.

Anyone else with same experiences?

TIA,
Fossie

cactus-jay’s picture

Yep, same here, Drupal 5.3 with FiveStar 5.x-1.8 clean install... the only error I see is in the FireFox error console:

Error: Drupal is not defined
Source File: http://XXX.XXX.XXX/modules/fivestar/jquery.rating.js
Line: 211

if (Drupal.jsEnabled) {
$(document).ready(function() {
$('div.fivestar-widget').rating();
$('input.fivestar-submit').hide();
});
}

TTFN

-- Jay

tuti’s picture

I have this problem but only in IE6 & IE7 and strangely enough in a teaser list view the first node teaser with fivestar rating enabled get's the pretty javascript stars but the rest falls back to non-javascript form. And if you view the full node by itself(where there's only is one fivestar ratings displayed) you always see the pretty javascript stars in IE6, IE7 and of course FF.

In firefox you always get the javascript version with javascript enabled.

tjholowaychuk’s picture

CACHED fivestar widgets seem to be doing this for me as well, and they work perfect the second I take off cache. My fix is below, it works fine but without the forms being generated dynamically the css and js never get added.

if (!$cache){
// fetch and generate markup, everything works.
}
else {
// add fivestar css and js, everything works now as well
fivestar_add_css();
fivestar_add_js();

...
}

tuti’s picture

where does that code go? in fivestar.module?

Did you just add it or replace anything?

tjholowaychuk’s picture

That was just an example, I was manually caching nodes, and when I displayed the cached ones the javascript for fivestar was not added. So you simply need to add it in manually, this may be the case with drupals built in cache modes as well

quicksketch’s picture

Status: Active » Closed (fixed)

Seems like all the reported cases so far have been either caused by theming or caching techniques. Since there isn't much we can do on the module side and there hasn't been any new activity, I'm going to close this issue. Please open a new issue if a similar problem comes up.