[Change notice] Move uses_options from plugin annotation to a class property

Adding a tag.

+++ b/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -678,10 +678,10 @@ abstract class ArgumentPluginBase extends HandlerBase {
+      if (empty($plugin->uses_options()) {

if (!$plugin->uses_options()) {

+++ b/lib/Drupal/views/Plugin/views/access/Permission.phpundefined
@@ -19,12 +19,16 @@ use Drupal\Core\Annotation\Translation;
+   * Overrides Drupal\views\Plugin\Plugin::$uses_options.

Is this a standard for variables? If yes then i would like to this on the other patch as well?

+++ b/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.phpundefined
@@ -2480,7 +2485,7 @@ abstract class DisplayPluginBase extends PluginBase {
-            if (!empty($plugin->definition['uses_options'])) {

I really like to get rid of all the !empty in views. Maybe we should cleanup views in general. For example it also doesn't make sense for $this->options['foo'] anymore, as we have a proper default value system.

Merging in the other patch and cleaning up some things, just to see that they're compatible.
#1744334: [Change notice] Move uses_row_class, uses_row_plugin, and uses_fields from plugin annotation to a class property

Committed.

I guess we should make a single one for http://drupal.org/node/1744334 or even how to convert plugins in general.

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447