When doing a commandline cvs commit on a drupal 5 contributed module

> cvs commit
cvs commit: Examining .
-- cut --
/cvs/drupal-contrib/contributions/modules/image_composition/Attic/image_composition.module,v <-- image_composition.module
new revision: 1.1.2.7; previous revision: 1.1.2.6
cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings.
-- cut --

This happens all the time when committing.

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Title: Using deprecated info format strings. » Looks like this has something to do with drupal.org cvs configuration or cvs version.

(From http://www.asturlinux.org/cgi-bin/bugzilla/show_bug.cgi?id=334)

cvs commit: warning: Set to use deprecated info format strings. Establish compatibility with the new info file format strings (add a temporary '1' in all info files after each '%' which doesn't represent a literal percent) and set UseNewInfoFmtStrings=yes in CVSROOT/config. After that, convert individual command lines and scripts to handle the new format at your leisure.

At this (http://bugzilla.mkgnu.net/show_bug.cgi?id=464#c9) is a crossref to cvshome.org which is currently dead) suggest the same.

Doing a cvs -d /tmp/newrepos init reveils the UseNewInfoFmtStrings=yes setting.

The info files refered at are less CVSROOT/*info
Is there an upgrade done lately?

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Title: Looks like this has something to do with drupal.org cvs configuration or cvs version. » Using deprecated info format strings.

(Sorry ... messed up the title)
Looks like this has something to do with drupal.org cvs configuration or cvs version.

hunmonk’s picture

hunmonk commented
Status: Active » Postponed (maintainer needs more info)

a quick assessment indicates this might not be worth the trouble to fix. we'll have to wait for dww to weigh in on this, though...

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

When doing command line committing this is (still) an annoying message ... but there is more to bother about ... what's dww's vote on this?

dww’s picture

dww
we/he/they
commented
Priority: Normal » Minor
Status: Postponed (maintainer needs more info) » Active

a) Yes, it's a mismatch between the version of CVS installed on cvs.d.o and the hook format strings we're using.
b) It's a harmless warning.
c) If we change it, we could break the access control scripts and other CVS + Drupal integration stuff, so it'd require good testing.
d) It's low priority to fix.

So, if someone cares, they'd have to:

- Setup CVS 1.12.*
- Create a repo
- Install all the xcvs-* stuff and configure
- Convert to the new format strings in the CVSROOT/*info hooks
- Make sure all the xcvs stuff is still working, getting the data each script expects, etc.

dww’s picture

dww
we/he/they
commented

http://ximbiot.com/cvs/manual/cvs-1.12.13/cvs_18.html#SEC189 for the interested reader.

Actually, the only hook that matters is loginfo. All the others already use valid, new format strings. This might be trivial to fix, but I'm still worried about someone testing well it before just changing the config on cvs.d.o.

dww’s picture

dww
we/he/they
commented

To be clear: we'll have to change both xcvs-loginfo.php and the CVSROOT/loginfo file. In particular:

Fixing `loginfo' could be a little tougher. The old style `loginfo' format strings caused a single space and comma separated argument to be passed in in place of the format string. This is what will continue to be generated due to the deprecated `1' you inserted into the format strings.

Since the new format separates each individual item and passes it into the script as a separate argument (for a good reason - arguments containing commas and/or white space are now parsable), to remove the deprecated `1' from your `loginfo' command line templates, you will most likely have to rewrite any scripts called by the hook to handle the new argument format.

So, we'd have to change the arg parsing code in xcvs-loginfo.php (for the better), if we wanted to switch format strings. We probably should do this, but, I repeat, it needs testing, and I still don't think it's particularly high priority.

jpetso’s picture

jpetso commented

For reference, I did the Version Control CVS backend with a hard (and sufficiently tested) requirement on new info format strings. No idea if project_release makes use of that as well, but if it doesn't then there's nothing to be done anymore.

hunmonk’s picture

hunmonk commented
Status: Active » Closed (won't fix)

with EOL approaching for this module, this isn't going to be addressed, esp. since versioncontrol API addresses the issue.

vinoth.3v’s picture

vinoth.3v commented
Version: 5.x-1.0 » 6.x-1.x-dev
Priority: Minor » Normal
Status: Closed (won't fix) » Postponed (maintainer needs more info)

I am also getting the same response from wincvs client. :( unable to commit/ displaying as dead files.

any help?

aclight’s picture

aclight commented
Version: 6.x-1.x-dev » 5.x-1.0
Priority: Normal » Minor
Status: Postponed (maintainer needs more info) » Closed (won't fix)

The "Using deprecated info format strings" message shouldn't affect your ability to actually commit code changes to the CVS repository, so you must have a different problem. Please take a look at the error messages you're getting, search d.o to see if this is already covered, and if not create a new issue (make sure to actually report the errors you are getting). Re-opening this issue with a different problem isn't the best way to deal with the problem.

vinoth.3v’s picture

vinoth.3v commented

Thanks for the response,

I am in the middle of development for the new module indic_script, today I have committed to CVS. The only error was explained previously & CVS is exited with code 0.

But in web CVS it is displaying the committed files as dead files!

don't know what I am missing :(

aclight’s picture

aclight commented

You're probably looking at the wrong branch. It looks like your DRUPAL-6--1 branch (http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/indic_scrip...) contains several files in the root directory of your module, while these files are marked as dead in HEAD (http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/indic_scrip...).

vinoth.3v’s picture

vinoth.3v commented

oh,

If i am committing with the tag HEAD it is displaying the following error
cvs commit: Up-to-date check failed for `indic_script.install'
***** CVS exited normally with code 1 *****

dww’s picture

dww
we/he/they
commented

@4vinoth: Which part of "Re-opening this issue with a different problem isn't the best way to deal with the problem." wasn't clear? I'm closing comments on this thread.