Hey there!

I wanted to change how the imagecrop functionality worked a little, so I tried to do a subclass of the ImageCrop class. That let me override the code in places, except that with all of the properties private, they were hidden from my subclass - I had to go through and change them to protected to work.

There's not much reason not to have the properties as protected instead of private, and it would make folks working with your code have an easier time of it.

Thanks!

(I'm planning on a patch later on, but I wanted to start up the ticket to remind me.)

(Awesome module, btw.)

CommentFileSizeAuthor
#1 imagecrop-protected-properties.patch2.04 KBc31ck

Comments

c31ck’s picture

Status: Active » Needs review
StatusFileSize
new2.04 KB

Patch that makes the private properties protected.

nils.destoop’s picture

Status: Needs review » Fixed

Thx for the patch. This has been committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.