The current version of this submodule depends on the Thickbox module, which is no longer supported: "I will not release a Drupal 7 version of the Thickbox module."

This probably means implementing the Colorbox module instead, but I would be a fan of just removing the popup alltogether and going with the (working) fallback of the standard form.

Comments

inventlogic’s picture

inventlogic commented

the module conditionally adds the javascript file sms_sendtophone.js via a module_exists test for thickbox.

However it also list the sms_sendtophone.js in the modules info file defeating the test for the thickbox module.

almaudoh’s picture

almaudoh commented
Issue summary: View changes
Status: Active » Fixed

Removed scripts[] line from sms_sendtophone.info so js is conditionally loaded. Also moved inclusion code away from hook_init, which is not best practice, into specific functions.

Committed and pushed to 7.x-1.x.

  • Commit 43f43e7 on 7.x-1.x by almaudoh: 
    Issue #1744686 by nmcclain, almaudoh: Fixed Thickbox dependency.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.