Closed (fixed)
Project:
Node-level Blocks
Version:
7.x-1.0-beta1
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
23 Aug 2012 at 13:35 UTC
Updated:
18 Apr 2014 at 14:55 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Dexter0015 commentedSame for me.
Comment #2
Dexter0015 commentedI think I manage to fix this issue.
Sorry for not displaying a patch but I'm not used to work with GIT for the moment so I will only explain the changes I've made.
In node_level_blocks.admin.inc around line 100, replace this :
By this :
Seems to works for me. If anyone can confirm...
Comment #3
ericclaeren commentedHi Dexter0015, thanks for your help, ran into the same problem.
I have rewritten your code to eliminate some else statements and I have attached a patch for this issue, maybe the maintainers could review it?
Comment #4
Dexter0015 commentedThanks.
Unfortunatly I wasn't able to apply your patch, git returns me the following error:
I guess where is a difference between our line numbering, don't know why.
So I apply your change myself and make a new patch (just in case).
I finally tried git ;)
Comment #5
ericclaeren commentedWeird, I made the patch with the git repo, as the Drupal guide for creating patching describes.
Have you also tried?
patch -p1 < node_level_blocks-1747994-2.patch
Thanks.
Comment #6
Dexter0015 commentedYou're right !
with :
patch -p1 < [patchname.patch]your patch is correctly applied.
I was using :
git apply -v [patchname.patch]as described in the drupal guide, and get the error previously mentionned.
Sorry, but I didn't know "patch -p" command (as I'm just starting using git...).
Could you tell me what is the difference between this 2 commands?
Comment #7
ericclaeren commentedHi, the difference (http://drupal.org/node/60108)
Comment #8
Dexter0015 commentedThanks !
Comment #9
Johnny vd Laar commentedThese changes are committed
Comment #10
Dexter0015 commentedThanks !
Unfortunately, I still have some error messages when I save a node without blocks affected.
In edit form only, creation form seems to be ok for me.
Comment #11
Johnny vd Laar commentedCan you provide me the error messages?
Comment #12
Dexter0015 commentedSorry,
This one appears on the top of the list :
Notice : Undefined index: settings dans node_level_blocks_block_list_alter() (ligne 140 dans /.../modules/node_level_blocks/node_level_blocks.module).
Then, this one appears several times :
Notice : Trying to get property of non-object dans overlay_block_list_alter() (ligne 440 dans /.../modules/overlay/overlay.module).
It seems to be related to the overlay (I guess) because if I edit a node without using overlay, I don't get any error...
Comment #13
Johnny vd Laar commentedokay that makes sense as I never use overlay ;-)
I will investigate.
Comment #14
Johnny vd Laar commentedI have committed a fix for this problem. Please review and reopen if needed.
Comment #15
Dexter0015 commentedI've updated my files from your last commit, but still have the same error messages.
Plus Drupal.org added this to the .info where Module's version is wrong :
Comment #16
Johnny vd Laar commentedHmm worked for me. I'll investigate again.
The info file still contained old code. I'll fix that too.
Comment #17
Johnny vd Laar commentedCommitted a fix for the info file but I can't seem to find any bugs in the node save now, using overlay. Can you verify if the bug still exists with the latest dev version?
Comment #18
Dexter0015 commentedOk, I've updated from the last dev version and installed it on a new drupal installation (7.19).
And...
I can't reproduce the bug. (so i apologize)
Maybe it's a conflict with on of the other modules I have on the website where I have the bug.
Anyway, thank you so much for taking the time to look for, and sorry for wasting of your time...
And I really thinking about stopping using the overlay as it seems to be really heavy and slow sometimes.
Comment #19
Johnny vd Laar commentedI found another bug in nlb with overlay that I just patched that added blocks to region -1.
Comment #20
Dexter0015 commentedI think you found the solution because I've just test your last commit and I don't have anymore error.
Thank you!