Closed (outdated)
Project:
Field Group
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Aug 2012 at 12:33 UTC
Updated:
1 Jun 2024 at 14:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Stalski commentedSome great work has been done here: http://drupal.org/sandbox/webflo/1413404. This will be the lead for the field_group integration on internationalization.
For this reason the t() is not used (anymore, would need to check) for labels and description. It is content in our opinion and thus of i18n_field_group.
Webflo has done some excellent work on that, just waiting on a release for it.
Comment #2
boran commentedThanks, but that sandbox is empty?
Comment #3
Stalski commentedNo, it isn't. Check : http://drupalcode.org/sandbox/webflo/1413404.git/tree/refs/heads/7.x-1.x
Comment #4
pere orgaI see that this is still not committed to 7.x-1.x-dev
Does anyone know if it will be at some point?
Cheers
Comment #5
Stalski commentedThis is not a commit on this module.
Comment #6
Stalski commentedSee
http://drupal.org/node/1751002
http://drupal.org/sandbox/opin/1762478
Another contrib will do all the work.
Comment #7
pere orgaGood to see a solution for this.
But is there any particular reason for having this in a different module?
And what is the difference between http://drupal.org/sandbox/webflo/1413404 and http://drupal.org/sandbox/opin/1762478 ? The two look inactive.
Comment #8
pere orgaIn my opinion this should be solved in this module and not in a separate one.
Comment #9
ovide commentedComment #10
caktux commentedHere's a git patch...
Comment #11
geek-merlinThis needs work.
* patches in #9 and #10 use t() which is not the way string translation should work (i18n assigns IDs to non-code strings so translations stick when source is changed)
* reviewed the 2 sandbox modules and code in https://drupal.org/sandbox/webflo/1413404 looks better to me
@Stalski: i also think this should live in field_group.module, would you as maintainer accept a patch that incorporates webflo's sandbox (with a namespace change) as a submodule?
Comment #12
Stalski commentedHi,
It could still go in for D7. Let's start from the sandbox of webflo and sync with him about this decision. I think he'll be happy.
So let's create a patch. There are some todo's in the code, so if someone is willing to make the final patch, let's have it :)
Comment #13
Georgique commentedIsn't description translated in field_group_pre_render_prepare()?
I believe it is, also it should be improved because there might be case when we translate empty string.
Patch is attached.
Comment #14
Georgique commentedComment #16
mibfire commentedhttps://drupal.org/sandbox/webflo/1413404 This module doesnt work on Commerce checkout pages. See: https://www.drupal.org/node/2368837
Comment #17
Georgique commentedLet's try this patch...
Comment #18
giupenni commentedI have to apply either the patch # 9 and # 10 to test?
Comment #19
bramvandenbulcke commentedI'm using the latest version of Field Group, version 1.5 and it's possible to translate the description of a field group. The strange thing is it doesn't show up easily in the translate tab (/admin/config/regional/translate/translate). I ran cron and cache clear 10 times and did string refresh 3 times (/admin/config/regional/translate/i18n_string, but the string didn't show up on the translate tab. But after creating a node of that type, it did!
Hopefully this offers some help to others with the same problem.
Comment #20
Fabioc79 commentedI spent half a day without being able to see field group labels/descriptions in the traslate page (/admin/config/regional/translate/translate). Finally I got the solution and I share it.
To make strings appear in the translation interface, you have to visit the page where those strings are printed IN THE LANGAUGE YOU WANT TO TRANSLATE (not in the default source language).
I hope this can help someone.
Comment #21
chris matthews commentedThe 4 year old patch in #17 to field_group.module applied cleanly to the latest field_group 7.x-1.x-dev, but still needs review (if still applicable).
Comment #22
julien.reulos commentedI can translate field_group descriptions with version 1.6, no need for this patch. This issue should be closed as Fixed.
Comment #23
anybodyComment #24
nils.destoop commented