This line:
$output = '<p>'. t("!someone currently !does_or_do not have any pending @buddy requests from other users.", array('!someone' => ($viewing_own_account ? t('You') : $account->name), '!does_or_do' => $viewing_own_account ? t('do') : t('does')) + buddylist_translation()) .'</p>';
seems wrong, especially that !does_or_do seems very specific to English grammar. Attached is a possible improvement.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | buddylist-viewing_own_account-translations.patch | 3.69 KB | john morahan |
| #3 | buddylist-does_or_do_0.patch | 1.48 KB | john morahan |
| buddylist-does_or_do.patch | 1.39 KB | john morahan |
Comments
Comment #1
john morahan commentedComment #2
dldege commentedThat originial code is also some of the ugliest php code I've ever seen crammed into one line. I'll take a look at the patch today.
Comment #3
john morahan commentedHmm... good point. Maybe it should be split up further?
Comment #4
dldege commentedI think its OK. I would like your ideas though on how to simplify the string handling in the module.
Comment #5
john morahan commentedFound some more strings with the same problem.
As far as the big-picture string handling thing goes... I don't know. The way it's done now (with @buddylist etc.) is theoretically wrong, but the "correct" alternative, leaving everything to the locale module, would likely have a performance impact on English-speaking sites using the module.
Comment #6
john morahan commentedI should mention, I also changed them to use theme('username') as you were doing in the other issue.
Comment #7
dldege commentedCool, I'll apply this on Monday and fix the other items you mentioned in http://drupal.org/node/181113 and hopefully we can get both of these committed then.
Thanks for your help - much appreciated.
Comment #8
dldege commentedI'm looking at this patch and http://drupal.org/node/178605 and there is some overlap. It might be easier to just output "None" like the other patch. http://drupal.org/node/178605 needs to be tweaked but has some good stuff? What do you think?