Menu target

1. Please correct the git link in the issue summary it should be :- http://git.drupal.org/sandbox/Oostie/1761940.git.
2. Please review your module from coder module and see the automated review here.
3. In .info file remove version as added by drupal.org and also remove files[] = menu_target.module
refer http://drupal.org/node/231036
4.In menu_target.admin.inc, you have used variables like menu_target_enabled, menu_target_type, menu_options_%.
Variables that the module has set using variable_set() must be uninstalled using hook_uninstall() refer http://api.drupal.org/api/drupal/developer!hooks!install.php/function/ho....

Added link to git repo

Hi Oostie, a few small issues came out of a manual review:

1. The first line of README.txt should possibly be changed from Menu Expandable to Menu Target?
2. An extremely minor point, but the file permissions don't need to set the executable flag. It won't affect most users but for some people who use Git on Windows (like I occasionally do) it causes issues.
3. Another, really, really, really minor point, but 'depricated' is spelled 'deprecated' on line 6 of menu_target.js.
4. More pedantry (sorry): line 10 of menu_target.admin.inc should be 'Adds extra form elements', rather than 'Adds aextra form elements'.

5. One question on the user interface: I'm curious as to why you have a 'Menu Target Enabled' setting, given that it's pretty easy to disable the module and re-enable it again. Is there a use case you had in mind?

   In general the coding style looks pretty solid, and the module provides handy functionality. I particularly like the settings for choosing between valide XHTML and deprecated target attributes.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

I've been checking the code and found no mistakes on it also the module works as it is meant to do so I guess this is RTBC.

Thanks for your contribution, Oostie!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

status