I had several node layouts exported in code and showing as Default with DS 1.6. Upgrading to 2.3 worked fine (update.php ran as well, and using ND and ND_contrib 2.9), and nodes still display correctly. However, on the Layouts listing page, the ones in code are now showing as Normal. All are Normal actually. If I edit any of the layouts, I see my custom layouts. Even if I make a change in the UI and save it, the layout still shows as Normal.

CommentFileSizeAuthor
#2 layout-status-all-normal-6413606-2.patch754 bytesdavemybes

Comments

davemybes’s picture

davemybes commented

This line: $display_settings = variable_get($module .'_display_settings_'. $type, array());, never finds anything in the variable table, so DS_SETTINGS_UI is always used. $module is "nd" for me, and no variables starting with "nd_display_settings_" exist. $type evaluates to the node type.

Seeing as the settings have now moved to ds_settings table, surely we shouldn't be doing a variable_get there, but rather looking in the new table? I see everything in that ds_settings table e.g. nd, blog, full, array of settings.

davemybes’s picture

davemybes commented
Status: Active » Needs review
StatusFileSize
new layout-status-all-normal-6413606-2.patch754 bytes

I figured it out. The variable_get needs to be replaced with ds_get_settings. Patch to 6x-2x attached.

xtfer’s picture

xtfer commented

Thanks. There's a few patches for me to review. I'll try and catch them shortly.

aspilicious’s picture

aspilicious commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

Closing all the drupal 6 issues as support for that version has been dropped.