Closed (fixed)
Project:
Internationalization
Version:
5.x-2.2
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2007 at 20:59 UTC
Updated:
12 May 2008 at 10:14 UTC
Jump to comment: Most recent file
Comments
Comment #1
gregglessubscribing
Comment #2
ALT83 commentedI just installed and tried this on my 5.3 installation - works perfectly!
Thanks a bunch!
Comment #3
JacobSingh commentedWorks like a charm. Oh man, this setup with token is so much better than before :)
Comment #4
xen commentedI'd suggest removing i18n_get_lang() and replacing it with an empty string. This will effectively strip the language prefix for nodes that has no set language, which makes sense for language neutral content.
Including that change, it works as advertised here.
Comment #5
knseibert commentedSounds good. If you could provide a patch? Would be appreciated. Could take some time until i will be able to post one.
Comment #6
pkej commentedSubscribing
Comment #7
Druppel.Hosting commentedThe patch in #4 by Xen.dk is pretty self explanatory:
on line 13 change:
To
Attached the new patch
Comment #8
xen commentedI don't think this should be a separate module. It's just 2 small functions that'll do nothing if the token module isn't enabled, so I've taken the liberty of integrating it into i18n.module and created a patch.
I've only renamed the functions and removed the check if i18n is enabled. Patch against 5.x-2.2, but it's just the addition of 2 functions, so it should be easy to move to HEAD or whereever.
Comment #9
akahn commentedThanks, Xen, this is very helpful. :)
Comment #10
greggles@xen.dk I think your patch is missing.
Comment #11
xen commented@greggles indeed it is.. I'll try again.
Comment #12
jose reyero commentedThe node part looks good, though as the node itself is passed as $object you could get the language straight from there.
I don't understand at all the taxonomy part
Comment #13
TBarregren commentedI have added this to the #227550: Patch bundle.
Comment #14
drewish commentedsince in D6 the language field is now in core there's a patch to add this to token's 6.x branch: #233076: Add token for node's language
Comment #15
manuel garcia commentedsubscribing... also having this issue with pathauto
Comment #16
jose reyero commentedI still don't understand why the taxonomy part and this 'language code' token is quite limited, language name would be nice too.
But ok, committed by popular demand :-)
(Thanks)
Comment #17
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.