The patch from #1517066: Implement hook_hook_info() introduced a php syntax error since the following functions are repeated:

/**
 * Let other modules do things before default entities are created on revert.
 */
function hook_uuid_entities_pre_rebuild($plan_name) {

}

/**
 * Let other modules do things after default entities are created on revert.
 */
function hook_uuid_entities_post_rebuild($plan_name) {

}

If I understand correctly those hooks should be pre_revert and post_revert so I've attached a patch to fix that.

Note that this is currently breaking the test on the test bot for this module.

Cheers.

Comments

lucascaro’s picture

Status: Active » Needs review
lucascaro’s picture

Assigned: Unassigned » lucascaro

Status: Needs review » Needs work

The last submitted patch, uuid-fix_syntax_error_repeated_function_names.patch, failed testing.

lucascaro’s picture

Status: Needs work » Needs review

So I forced the tests to run and as you can see after this patch there aren't php syntax errors anymore. Yay!

The tests are still failing due to other erros, for example requiring optional modules (fixed with #1777980: Tests fail if optional deploy module is not present. ) and there are still some tests left that are failing but IMO this patch is one step forward in order to fix that.

Setting to needs review since if those two function names are correct in the patch this should be committed to 7.x-1.x asap.

jonhattan’s picture

Status: Needs review » Reviewed & tested by the community

Indeed it seems a copy&paste error.

mgifford’s picture

mgifford’s picture

Patch still applies nicely. I'm not sure if the bot really applies here, but it was listed as broken prior.

Curious what needs to be done to bring this into the git repo.

socialnicheguru’s picture

Is this still an issue or will the old naming remain?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, uuid-fix_syntax_error_repeated_function_names.patch, failed testing.

skwashd’s picture

Issue summary: View changes
Status: Needs work » Fixed

Thanks for the patch. This was fixed some time ago using a fix identical to this patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.