The Etherpad lite Lite module allows to integrate Etherpad Lite into Drupal. The module provides a client and a field type. Thus, a pad can be attached to any entity type. Authentication for group pads is managed by Drupal.

Project Page: http://drupal.org/sandbox/webflo/1255474
Repository: git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/webflo/1255474.git etherpad_lite
Drupal Version 7

Comments

Anks’s picture

Anks commented
Status: Needs review » Needs work

Hi webflo

Manual Review:

[1] README.txt file is missing. There should be README.txt file in your module for information and configuration settings of module.

[2] In etherpad_lite.module There is a function

"function _etherpad_frame"

It should be rename - Functions should be prefixed with your module name.

Like
" function etherpad_lite_frame "

mschudders’s picture

mschudders commented

Review:

FILE: ...review/sites/all/modules/pareview_temp/test_candidate/etherpad_lite.css
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | Multiple CSS properties should be listed in alphabetical order
4 | ERROR | Multiple CSS properties should be listed in alphabetical order
5 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Please fix these errors: found @http://ventral.org/pareview/httpgitdrupalorgsandboxwebflo1255474git

Also remove the master branch.
http://drupal.org/node/1127732

Kind regards

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.