I'm using Image Assist with the latest Drupal 5 release and 5.x-1.5 of the Drupal Image module.

When in a node I select the image attach icon and am able to upload a new image successfully. If I select the dropdown to view all images, not just mine nothing happens, though through firefox console I saw the error:

formObj['edit-browse'] has no properties
browse = formObj['edit-browse'].value;

If you look in the frame that this is looking to you will see that there is no such field as 'edit-browse', though there is one that is called 'edit-img-assist-header-form-browse'

If I try to insert an image then I get something similar:

formObj['edit-insertmode'] has no properties

There is a field called 'edit-img-assist-properties-form-insertmode'

CommentFileSizeAuthor
#4 img_assist-DRUPAL-5_8.patch1.54 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Category: support » bug
Priority: Critical » Normal
Status: Active » Fixed

I'm not able to reproduce this bug with the latest development snapshot of Img_Assist.
Could you please update your copy of Img_Assist to the latest version?
Do not forget to clear your browser cache after updating. There have been several JavaScript and CSS fixes.

Feel free to re-open this issue again, if you still encounter this bug.

ztolley1’s picture

ztolley1 commented
Status: Fixed » Active

This is the latest dev version I am using and it happens for sure. I downloaded the latest dev release 10 mins ago and same happens with IE, Firefox and Safari.

The issue seems to be related to forms and form names. The javascript calls forms using a short name (e.g. edit-insertmode') while the html that has been generated contains a longer form name (e.g. 'edit-img-assist-properties-form-insertmode') complete with module name within it's name.

So I take it it's something to do with the form generation code or the code that generates the field names it will use to make calls.

I'll take a look myself too in case I can figure it out but weird that you don't see it, so it must be something with my drupal but then that would surely break any form code.

thebrotherofasis’s picture

thebrotherofasis commented

I recommend to use FCKeditor and IMCE for node / image handling.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: Unassigned » sun
Status: Active » Needs review
StatusFileSize
new img_assist-DRUPAL-5_8.patch1.54 KB

Could you please test the attached patch? See http://drupal.org/patch/apply for further information about how to apply patches.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

@ztolley1: Have you been able to test the patch?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Can't attach images or browse other images » Javascript calls using wrong form id
Status: Needs review » Fixed

Committed last patch.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.